Add short circuit case for self assignment...

base/pickle.h

 // Copyright (c) 2006-2008 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef BASE_PICKLE_H__
 #define BASE_PICKLE_H__
 
 #include <string>
 
 #include "base/basictypes.h"
@@ skipping 13 matching lines @@
 // what value types to read and in what order to read them as the Pickle does
 // not keep track of the type of data written to it.
 //
 // The Pickle's data has a header which contains the size of the Pickle's
 // payload.  It can optionally support additional space in the header.  That
 // space is controlled by the header_size parameter passed to the Pickle
 // constructor.
 //
 class Pickle {
  public:
-  ~Pickle();
+  virtual ~Pickle();

[wtc, 2011/09/21 23:37:04]

jar: I was wondering why the Pickle class has a virtual
destructor, and I tracked it down to this CL.

The Pickle class does not have any virtual method, so it
is strange for it to have a virtual destructor.

I am not convinced that the reason you gave is correct.
In any case, I suggest you add a comment to the source code
to explain why.  This will save the next person a few minutes
to answer this question.  Thanks.

 
   // Initialize a Pickle object using the default header size.
   Pickle();
 
   // Initialize a Pickle object with the specified header size in bytes, which
   // must be greater-than-or-equal-to sizeof(Pickle::Header).  The header size
   // will be rounded up to ensure that the header size is 32bit-aligned.
   explicit Pickle(int header_size);
 
   // Initializes a Pickle from a const block of data.  The data is not copied;
@@ skipping 185 matching lines @@
   // Allocation size of payload (or -1 if allocation is const).
   size_t capacity_;
   size_t variable_buffer_offset_;  // IF non-zero, then offset to a buffer.
 
   FRIEND_TEST(PickleTest, Resize);
   FRIEND_TEST(PickleTest, FindNext);
   FRIEND_TEST(PickleTest, IteratorHasRoom);
 };
 
 #endif  // BASE_PICKLE_H__