Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(71)

Unified Diff: master/skia_master_scripts/housekeeping_percommit_factory.py

Issue 159793002: Test android tool for building makefile. (Closed) Base URL: https://skia.googlesource.com/buildbot.git@master
Patch Set: Reupload due to chunk error mismatch Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | tools/tests/factory_configuration/expected/Housekeeper-PerCommit » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: master/skia_master_scripts/housekeeping_percommit_factory.py
diff --git a/master/skia_master_scripts/housekeeping_percommit_factory.py b/master/skia_master_scripts/housekeeping_percommit_factory.py
index 5a02c3f8f2425400ce0298fd969b391837ce49c5..20b83cc0de8349be39d9729e1f3a2d4d1e42022a 100644
--- a/master/skia_master_scripts/housekeeping_percommit_factory.py
+++ b/master/skia_master_scripts/housekeeping_percommit_factory.py
@@ -39,6 +39,7 @@ class HouseKeepingPerCommitFactory(skia_factory.SkiaFactory):
self.UpdateSteps()
self.Compile(clobber)
+ # TODO(borenet): Move these to a self-tests bot (http://skbug.com/2144)
# Build tools and run their unittests.
self._skia_cmd_obj.AddRunCommand(
command=self.TargetPath.join('tools', 'tests', 'run.sh'),
@@ -49,6 +50,12 @@ class HouseKeepingPerCommitFactory(skia_factory.SkiaFactory):
command=self.TargetPath.join('gm', 'tests', 'run.sh'),
description='RunGmSelfTests')
+ # Run unittests for Anroid platform_tools
+ self._skia_cmd_obj.AddRunCommand(
+ command=['python', self.TargetPath.join('platform_tools', 'android',
+ 'tests', 'run_all.py')],
+ description='RunAndroidPlatformSelfTests')
+
# Check for static initializers.
self.AddSlaveScript(script='detect_static_initializers.py',
description='DetectStaticInitializers')
« no previous file with comments | « no previous file | tools/tests/factory_configuration/expected/Housekeeper-PerCommit » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698