Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(370)

Unified Diff: base/base.gyp

Issue 159791: Move test_file_util out of libbase. Test code should not be mixed with production code. (Closed)
Patch Set: Created 11 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/chrome.gyp » ('j') | chrome/chrome.gyp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/base.gyp
diff --git a/base/base.gyp b/base/base.gyp
index 94d2cfb2ca2dd15bd1d5bda44c1d8fcf70a71abf..6c76edb0dc03875c2c48526e389dbeaa7912f1e7 100644
--- a/base/base.gyp
+++ b/base/base.gyp
@@ -297,11 +297,6 @@
'system_monitor_posix.cc',
'system_monitor_win.cc',
'task.h',
- 'test_file_util.h',
- 'test_file_util_linux.cc',
- 'test_file_util_mac.cc',
- 'test_file_util_posix.cc',
- 'test_file_util_win.cc',
'thread.cc',
'thread.h',
'thread_collision_warner.cc',
@@ -699,6 +694,42 @@
'type': '<(library)',
'dependencies': [
'base',
+ ],
+ 'sources': [
+ 'test_file_util.h',
+ 'test_file_util_linux.cc',
+ 'test_file_util_mac.cc',
+ 'test_file_util_posix.cc',
+ 'test_file_util_win.cc',
+ ],
+ 'conditions': [
+ [ 'OS == "linux"', {
+ 'sources/': [ ['exclude', '_(mac|win|chromeos)\\.cc$'],
+ ['exclude', '\\.mm?$' ] ],
+ 'conditions': [
+ [ 'chromeos==1', {
+ 'sources/': [ ['include', '_chromeos\\.cc$'] ]
+ },
+ ],
+ ],
+ },
+ ],
+ [ 'OS == "mac"', {
+ 'sources/': [ ['exclude', '_(linux|win|chromeos)\\.cc$'] ],
+ },
+ ],
+ [ 'OS == "win"', {
+ 'sources/': [ ['exclude', '_(linux|mac|posix|chromeos)\\.cc$'],
+ ['exclude', '\\.mm?$' ] ],
+ },
+ ],
+ ],
+ },
+ {
+ 'target_name': 'test_support_perf',
+ 'type': '<(library)',
+ 'dependencies': [
+ 'base',
'../testing/gtest.gyp:gtest',
],
'sources': [
« no previous file with comments | « no previous file | chrome/chrome.gyp » ('j') | chrome/chrome.gyp » ('J')

Powered by Google App Engine
This is Rietveld 408576698