Issue 159791: Move test_file_util out of libbase. Test code should not be mixed with production code.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 159791: Move test_file_util out of libbase. Test code should not be mixed with production code. (Closed)

Created:
11 years, 4 months ago by Paweł Hajdan Jr.

Modified:
9 years, 7 months ago

Reviewers:
Mark Mentovai, huanr

CC:
chromium-reviews_googlegroups.com

Visibility:
Public.

Description

Move test_file_util out of libbase. Test code should not be mixed with production code. Rename previous test_support_base to test_support_perf. I couldn't just add things to test_support_base because one file there defined main, and it would produce link conflict for new users of test_support_base. TEST=none http://crbug.com/18101 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=22291

Patch Set 1 #

Total comments: 1

Created: 11 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+45 lines, -7 lines)			Patch
M	base/base.gyp	View	2 chunks	+36 lines, -5 lines	0 comments	Download
M	chrome/chrome.gyp	View	6 chunks	+6 lines, -0 lines	1 comment	Download
M	net/net.gyp	View	3 chunks	+3 lines, -2 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Mark Mentovai

11 years, 4 months ago (2009-08-03 16:36:48 UTC) #2

LGTM

I've wanted to do this in the past but as I recall there was some reason that we
couldn't do it.  There may be an open bug on it, there may be a bug that was
closed as wontfix, or we may have just decided it sucked without filing a bug.

I looked for other uses of test_support_base (since you're changing its meaning)
and found tools/buildbot/scripts/slave/chromium/target-tests.py.  I'm not
entirely sure what that script is all about, but you might want to add
test_support_perf to it.

http://codereview.chromium.org/159791/diff/1/3
File chrome/chrome.gyp (right):

http://codereview.chromium.org/159791/diff/1/3#newcode3479
Line 3479: '../base/base.gyp:test_support_base',
Is this really needed here?  Isn't this already coming in via
test_support_common?

Expand Messages | Collapse Messages