content/renderer/media/webaudio_capturer_source.cc - Issue 15979027: start/stop the source of the capturer when 1st audiotrack/last audiotrack is added/removed

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/media/webaudio_capturer_source.cc

Issue 15979027: start/stop the source of the capturer when 1st audiotrack/last audiotrack is added/removed (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 7 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/renderer/media/media_stream_dependency_factory.cc ('K') | « content/renderer/media/media_stream_dependency_factory.cc ('k') | content/renderer/media/webrtc_audio_capturer.h » ('j') | content/renderer/media/webrtc_audio_capturer.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/renderer/media/webaudio_capturer_source.cc

diff --git a/content/renderer/media/webaudio_capturer_source.cc b/content/renderer/media/webaudio_capturer_source.cc

index ea71dd2fb9d1d44fc9ee19f4e6a8901d14acdb7b..0ab8dc360e605daf0fb3d6fba63fbacfd3084436 100644

--- a/content/renderer/media/webaudio_capturer_source.cc

+++ b/content/renderer/media/webaudio_capturer_source.cc

@@ -37,7 +37,6 @@ void WebAudioCapturerSource::setFormat(

ChannelLayout channel_layout =

number_of_channels == 1 ? CHANNEL_LAYOUT_MONO : CHANNEL_LAYOUT_STEREO;

capturer_->SetCapturerSource(this, channel_layout, sample_rate);

- capturer_->Start();

henrika (OOO until Aug 14) 2013/06/05 09:09:20 Why was this line removed?

no longer working on chromium 2013/06/05 16:29:45 capturer_ will be automatically started when the f

} else {

// TODO(crogers): Handle more than just the mono and stereo cases.

LOG(WARNING) << "WebAudioCapturerSource::setFormat() : unhandled format.";