include/v8.h - Issue 15979014: remove V8_ALLOW_ACCESS_TO_PERSISTENT_IMPLICIT and V8_ALLOW_ACCESS_TO_PERSISTENT_ARROW

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: include/v8.h

Issue 15979014: remove V8_ALLOW_ACCESS_TO_PERSISTENT_IMPLICIT and V8_ALLOW_ACCESS_TO_PERSISTENT_ARROW (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Created 7 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: include/v8.h

diff --git a/include/v8.h b/include/v8.h

index 5b0b30493b29dd73e95b6fdb06403f8030cc46da..54b513a0220e4b6012c723d7e0bc5ad7749aee4b 100644

--- a/include/v8.h

+++ b/include/v8.h

@@ -764,10 +764,7 @@ template <class T> class Persistent // NOLINT

#ifndef V8_USE_UNSAFE_HANDLES

-#ifndef V8_ALLOW_ACCESS_TO_PERSISTENT_IMPLICIT

private:

-#endif

// TODO(dcarney): make unlinkable before cutover

V8_INLINE(Persistent(const Persistent& that)) : val_(that.val_) {}

// TODO(dcarney): make unlinkable before cutover

@@ -790,11 +787,8 @@ template <class T> class Persistent // NOLINT

}

// TODO(dcarney): remove before cutover

V8_INLINE(T* operator*() const) { return val_; }

- public:

-#ifndef V8_ALLOW_ACCESS_TO_PERSISTENT_ARROW

private:

-#endif

// TODO(dcarney): remove before cutover

V8_INLINE(T* operator->() const) { return val_; }

public:

« no previous file with comments | « no previous file | src/api.cc » ('j') | no next file with comments »