Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(60)

Issue 15979013: Refactor partial interface resolving and merging into InterfaceMerger.pm (Closed)

Created:
7 years, 6 months ago by Nils Barth (inactive)
Modified:
7 years, 6 months ago
Reviewers:
haraken
CC:
blink-reviews, jsbell+bindings_chromium.org, eae+blinkwatch, abarth-chromium, marja+watch_chromium.org, adamk+blink_chromium.org, Nate Chapin, kojih
Visibility:
Public.

Description

Refactor partial interface resolving and merging into InterfaceMerger.pm This is a more substantial refactoring than SemanticAnalyzer.pm http://crrev.com/15984007 as it takes two sections of the body of generate-bindings.pl and puts them into functions. This makes the body of generate-bindings.pl very short (30 lines + parsing and headers), which makes it easier both: 1. to output/input JSON, since flow easier, and 2. to port to Python, since easier to review This also removes “supplemental” from “supplemental dependencies”, as “supplemental” has technical meaning and, further, is redundant. In Web IDL, “supplemental” is only used in the phrase “supplemental interface”, which uses the “implements” keyword. We're using it for partial interfaces, which is misleading, and we don't process “implements” (we parse and discard). Thus it's clearer to remove it and just call it “dependencies”. Reference: http://www.w3.org/TR/WebIDL/#dfn-supplemental-interface supplemental interface BUG=239771

Patch Set 1 #

Patch Set 2 : Handle empties #

Unified diffs Side-by-side diffs Delta from patch set Stats (+161 lines, -108 lines) Patch
M Source/bindings/derived_sources.gyp View 8 chunks +9 lines, -8 lines 0 comments Download
A Source/bindings/scripts/InterfaceMerger.pm View 1 chunk +141 lines, -0 lines 0 comments Download
M Source/bindings/scripts/generate-bindings.pl View 1 4 chunks +11 lines, -100 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Nils Barth (inactive)
Hi haraken, Here's the more substantial refactoring; this reduces the main body of generate-bindings.pl to ...
7 years, 6 months ago (2013-06-03 08:40:41 UTC) #1
haraken
7 years, 6 months ago (2013-06-03 08:50:41 UTC) #2
Regarding "supplemental dependency", I think we should call "partial
dependency". We did the rename for other parts, but forgot it for
generate-binding.pl.

Still what's the point of splitting generate-bindings.pl? Why can't you post
Python changes incrementally, keeping the current generate-bindings.pl? I don't
see the benefit of splitting generate-bindings.pl. It will just make people
confused to make changes.

Powered by Google App Engine
This is Rietveld 408576698