Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1602)

Unified Diff: runtime/vm/flow_graph_builder.h

Issue 15979010: Fix two bugs in the Dart VM's super-noSuchMethod invocation. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: improved version Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/vm/flow_graph_builder.h
===================================================================
--- runtime/vm/flow_graph_builder.h (revision 23536)
+++ runtime/vm/flow_graph_builder.h (working copy)
@@ -101,13 +101,13 @@
class FlowGraphBuilder: public ValueObject {
public:
// The inlining context is NULL if not inlining.
- FlowGraphBuilder(const ParsedFunction& parsed_function,
+ FlowGraphBuilder(ParsedFunction* parsed_function,
const Array& ic_data_array,
InlineExitCollector* exit_collector);
FlowGraph* BuildGraph();
- const ParsedFunction& parsed_function() const { return parsed_function_; }
+ ParsedFunction* parsed_function() const { return parsed_function_; }
const Array& ic_data_array() const { return ic_data_array_; }
void Bailout(const char* reason);
@@ -151,7 +151,7 @@
return parameter_count() + num_stack_locals_;
}
- const ParsedFunction& parsed_function_;
+ ParsedFunction* parsed_function_;
const Array& ic_data_array_;
const intptr_t num_copied_params_;
@@ -341,7 +341,8 @@
const Class& target_class,
AstNode* receiver,
const String& method_name,
- ArgumentListNode* method_arguments);
+ ArgumentListNode* method_arguments,
+ bool save_last_arg);
StaticCallInstr* BuildThrowNoSuchMethodError(intptr_t token_pos,
const Class& function_class,
@@ -362,6 +363,11 @@
const AbstractType& dst_type,
const String& dst_name);
+ // Helpers for allocating and deallocating temporary locals on top of the
+ // expression stack.
+ LocalVariable* EnterTempLocalScope(Value* value);
+ Definition* ExitTempLocalScope(LocalVariable* var);
+
void BuildLetTempExpressions(LetNode* node);
private:

Powered by Google App Engine
This is Rietveld 408576698