Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(623)

Issue 15979009: [Mac] Move the large block of NSEvent forward declarations to a shared header. (Closed)

Created:
7 years, 6 months ago by Robert Sesek
Modified:
7 years, 6 months ago
Reviewers:
Mark Mentovai
CC:
chromium-reviews, erikwright+watch_chromium.org, sail+watch_chromium.org, Nico
Visibility:
Public.

Description

[Mac] Move the large block of NSEvent forward declarations to a shared header. BUG=none R=mark@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=203155

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+53 lines, -65 lines) Patch
M base/PRESUBMIT.py View 1 chunk +2 lines, -1 line 0 comments Download
M base/base.gypi View 1 chunk +1 line, -0 lines 0 comments Download
A base/mac/sdk_forward_declarations.h View 1 chunk +48 lines, -0 lines 0 comments Download
M chrome/browser/renderer_host/chrome_render_widget_host_view_mac_delegate.mm View 2 chunks +1 line, -35 lines 0 comments Download
M ui/message_center/cocoa/popup_controller.mm View 2 chunks +1 line, -29 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Robert Sesek
Split from https://codereview.chromium.org/15757005/
7 years, 6 months ago (2013-05-30 14:24:59 UTC) #1
Mark Mentovai
LGTM
7 years, 6 months ago (2013-05-30 14:51:26 UTC) #2
Robert Sesek
7 years, 6 months ago (2013-05-30 16:09:17 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r203155.

Powered by Google App Engine
This is Rietveld 408576698