Making credit card number un-editable in Wallet mode.

chrome/browser/ui/autofill/autofill_dialog_controller_browsertest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/bind.h"
 #include "base/memory/ref_counted.h"
 #include "base/message_loop.h"
 #include "base/time.h"
 #include "base/utf_string_conversions.h"
 #include "chrome/browser/ui/autofill/autofill_dialog_controller_impl.h"
 #include "chrome/browser/ui/autofill/autofill_dialog_view.h"
 #include "chrome/browser/ui/autofill/data_model_wrapper.h"
 #include "chrome/browser/ui/autofill/testable_autofill_dialog_view.h"
 #include "chrome/browser/ui/browser.h"
 #include "chrome/browser/ui/tabs/tab_strip_model.h"
 #include "chrome/test/base/in_process_browser_test.h"
 #include "components/autofill/browser/autofill_common_test.h"
 #include "components/autofill/browser/autofill_metrics.h"
 #include "components/autofill/browser/test_personal_data_manager.h"
+#include "components/autofill/browser/wallet/wallet_test_util.h"
 #include "components/autofill/common/form_data.h"
 #include "components/autofill/common/form_field_data.h"
 #include "content/public/test/test_utils.h"
 #include "testing/gtest/include/gtest/gtest.h"
 
 namespace autofill {
 
 namespace {
 
 void MockCallback(const FormStructure*, const std::string&) {}
@@ skipping 50 matching lines @@
                                const FormData& form_data,
                                const AutofillMetrics& metric_logger,
                                scoped_refptr<content::MessageLoopRunner> runner,
                                const DialogType dialog_type)
       : AutofillDialogControllerImpl(contents,
                                      form_data,
                                      GURL(),
                                      dialog_type,
                                      base::Bind(&MockCallback)),
         metric_logger_(metric_logger),
-        message_loop_runner_(runner) {
-    DisableWallet();
-  }
+        message_loop_runner_(runner) {}
 
   virtual ~TestAutofillDialogController() {}
 
   virtual void ViewClosed() OVERRIDE {
     message_loop_runner_->Quit();
     AutofillDialogControllerImpl::ViewClosed();
   }
 
   virtual string16 InputValidityMessage(
       AutofillFieldType type,
@@ skipping 16 matching lines @@
   // Increase visibility for testing.
   AutofillDialogView* view() { return AutofillDialogControllerImpl::view(); }
   const DetailInput* input_showing_popup() const {
     return AutofillDialogControllerImpl::input_showing_popup();
   }
 
   TestPersonalDataManager* GetTestingManager() {
     return &test_manager_;
   }
 
+  using AutofillDialogControllerImpl::DisableWallet;
+
  protected:
   virtual PersonalDataManager* GetManager() OVERRIDE {
     return &test_manager_;
   }
 
  private:
   // To specify our own metric logger.
   virtual const AutofillMetrics& GetMetricLogger() const OVERRIDE {
     return metric_logger_;
   }
@@ skipping 120 matching lines @@
   controller()->OnAutocheckoutError();
   controller()->view()->GetTestableView()->CancelForTesting();
   RunMessageLoop();
 
   EXPECT_EQ(AutofillMetrics::AUTOCHECKOUT_FAILED,
             metric_logger().autocheckout_status());
 }
 
 IN_PROC_BROWSER_TEST_F(AutofillDialogControllerTest, FillInputFromAutofill) {
   InitializeControllerOfType(DIALOG_TYPE_REQUEST_AUTOCOMPLETE);
+  controller()->DisableWallet();
 
   AutofillProfile full_profile(test::GetFullProfile());
   controller()->GetTestingManager()->AddTestingProfile(&full_profile);
 
   const DetailInputs& inputs =
       controller()->RequestedFieldsForSection(SECTION_SHIPPING);
   const DetailInput& triggering_input = inputs[0];
   string16 value = full_profile.GetRawInfo(triggering_input.type);
   TestableAutofillDialogView* view = controller()->view()->GetTestableView();
   view->SetTextContentsOfInput(triggering_input,
@@ skipping 57 matching lines @@
 
   controller()->view()->GetTestableView()->SubmitForTesting();
   EXPECT_TRUE(controller()->ShouldShowDetailArea());
   EXPECT_FALSE(controller()->ShouldShowProgressBar());
 }
 
 // Tests that changing the value of a CC expiration date combobox works as
 // expected when Autofill is used to fill text inputs.
 IN_PROC_BROWSER_TEST_F(AutofillDialogControllerTest, FillComboboxFromAutofill) {
   InitializeControllerOfType(DIALOG_TYPE_REQUEST_AUTOCOMPLETE);
+  controller()->DisableWallet();
 
   CreditCard card1;
   test::SetCreditCardInfo(&card1, "JJ Smith", "4111111111111111", "12", "2018");
   controller()->GetTestingManager()->AddTestingCreditCard(&card1);
   CreditCard card2;
   test::SetCreditCardInfo(&card2, "B Bird", "3111111111111111", "11", "2017");
   controller()->GetTestingManager()->AddTestingCreditCard(&card2);
   AutofillProfile full_profile(test::GetFullProfile());
   controller()->GetTestingManager()->AddTestingProfile(&full_profile);
 
@@ skipping 61 matching lines @@
       EXPECT_EQ(wrapper2.GetInfo(input.type),
                 view->GetTextContentsOfInput(input));
     } else if (input.type == CREDIT_CARD_VERIFICATION_CODE) {
       EXPECT_TRUE(view->GetTextContentsOfInput(input).empty());
     } else {
       EXPECT_EQ(wrapper1.GetInfo(input.type),
                 view->GetTextContentsOfInput(input));
     }
   }
 }
+
+// Tests that credit card number is disabled while editing a Wallet instrument.
+IN_PROC_BROWSER_TEST_F(AutofillDialogControllerTest, WalletCreditCardDisabled) {
+  InitializeControllerOfType(DIALOG_TYPE_REQUEST_AUTOCOMPLETE);
+  controller()->OnUserNameFetchSuccess("user@example.com");
+
+  scoped_ptr<wallet::WalletItems> wallet_items = wallet::GetTestWalletItems();
+  wallet_items->AddInstrument(wallet::GetTestMaskedInstrument());
+  controller()->OnDidGetWalletItems(wallet_items.Pass());
+
+  // Click "Edit" in the billing section (while using Wallet).
+  controller()->EditClickedForSection(SECTION_CC_BILLING);
+
+  const DetailInputs& edit_inputs =
+      controller()->RequestedFieldsForSection(SECTION_CC_BILLING);
+  size_t i;
+  for (i = 0; i < edit_inputs.size(); ++i) {
+    if (edit_inputs[i].type == CREDIT_CARD_NUMBER) {
+      EXPECT_FALSE(edit_inputs[i].editable);
+      break;
+    }
+  }
+  ASSERT_LT(i, edit_inputs.size());
+
+  // Select "Add new billing info..." while using Wallet.
+  ui::MenuModel* model = controller()->MenuModelForSection(SECTION_CC_BILLING);
+  model->ActivatedAt(model->GetItemCount() - 2);
+
+  const DetailInputs& add_inputs =
+      controller()->RequestedFieldsForSection(SECTION_CC_BILLING);
+  for (i = 0; i < add_inputs.size(); ++i) {
+    if (add_inputs[i].type == CREDIT_CARD_NUMBER) {
+      EXPECT_TRUE(add_inputs[i].editable);
+      break;
+    }
+  }
+  ASSERT_LT(i, add_inputs.size());
+}
 #endif  // defined(TOOLKIT_VIEWS)
 
 }  // namespace autofill