Making credit card number un-editable in Wallet mode.

chrome/browser/ui/autofill/autofill_dialog_controller_browsertest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/bind.h"
 #include "base/memory/ref_counted.h"
 #include "base/message_loop.h"
 #include "base/time.h"
 #include "base/utf_string_conversions.h"
 #include "chrome/browser/ui/autofill/autofill_dialog_controller_impl.h"
 #include "chrome/browser/ui/autofill/autofill_dialog_view.h"
 #include "chrome/browser/ui/autofill/data_model_wrapper.h"
 #include "chrome/browser/ui/autofill/testable_autofill_dialog_view.h"
 #include "chrome/browser/ui/browser.h"
 #include "chrome/browser/ui/tabs/tab_strip_model.h"
 #include "chrome/test/base/in_process_browser_test.h"
 #include "components/autofill/browser/autofill_common_test.h"
 #include "components/autofill/browser/autofill_metrics.h"
 #include "components/autofill/browser/test_personal_data_manager.h"
+#include "components/autofill/browser/wallet/wallet_test_util.h"
 #include "components/autofill/common/form_data.h"
 #include "components/autofill/common/form_field_data.h"
 #include "content/public/test/test_utils.h"
 #include "testing/gtest/include/gtest/gtest.h"
 
 namespace autofill {
 
 namespace {
 
 void MockCallback(const FormStructure*, const std::string&) {}
@@ skipping 50 matching lines @@
                                const FormData& form_data,
                                const AutofillMetrics& metric_logger,
                                scoped_refptr<content::MessageLoopRunner> runner,
                                const DialogType dialog_type)
       : AutofillDialogControllerImpl(contents,
                                      form_data,
                                      GURL(),
                                      dialog_type,
                                      base::Bind(&MockCallback)),
         metric_logger_(metric_logger),
         message_loop_runner_(runner) {

[Evan Stade, 2013/05/25 00:41:19]

{} on same line

[Dan Beam, 2013/05/25 02:36:57]

Done.

-    DisableWallet();
   }
 
   virtual ~TestAutofillDialogController() {}
 
   virtual void ViewClosed() OVERRIDE {
     message_loop_runner_->Quit();
     AutofillDialogControllerImpl::ViewClosed();
   }
 
   virtual string16 InputValidityMessage(
@@ skipping 309 matching lines @@
       EXPECT_EQ(wrapper2.GetInfo(input.type),
                 view->GetTextContentsOfInput(input));
     } else if (input.type == CREDIT_CARD_VERIFICATION_CODE) {
       EXPECT_TRUE(view->GetTextContentsOfInput(input).empty());
     } else {
       EXPECT_EQ(wrapper1.GetInfo(input.type),
                 view->GetTextContentsOfInput(input));
     }
   }
 }
+
+// Tests that credit card number is disabled while editing a Wallet instrument.
+IN_PROC_BROWSER_TEST_F(AutofillDialogControllerTest, WalletCreditCardDisabled) {
+  InitializeControllerOfType(DIALOG_TYPE_REQUEST_AUTOCOMPLETE);
+  controller()->OnUserNameFetchSuccess("user@example.com");
+
+  scoped_ptr<wallet::WalletItems> wallet_items = wallet::GetTestWalletItems();
+  wallet_items->AddInstrument(wallet::GetTestMaskedInstrument());
+  controller()->OnDidGetWalletItems(wallet_items.Pass());
+
+  controller()->EditClickedForSection(SECTION_CC_BILLING);
+
+  const DetailInputs& inputs =
+      controller()->RequestedFieldsForSection(SECTION_CC_BILLING);
+  size_t i;
+  for (i = 0; i < inputs.size(); ++i) {
+    if (inputs[i].type == CREDIT_CARD_NUMBER) {
+      EXPECT_FALSE(inputs[i].enabled);
+      break;
+    }
+  }
+  ASSERT_LT(i, inputs.size());
+
+  DetailOutputMap output;
+  controller()->view()->GetUserInput(SECTION_CC_BILLING, &output);
+  for (DetailOutputMap::const_iterator it = output.begin(); it != output.end();
+      ++it) {

[Evan Stade, 2013/05/25 00:41:19]

one more space of indent

[Dan Beam, 2013/05/25 02:36:57]

removed

+    EXPECT_NE(CREDIT_CARD_NUMBER, it->first->type);
+  }
+}
 #endif  // defined(TOOLKIT_VIEWS)
 
 }  // namespace autofill