Issue 1597893003: Don't include implicit initializing formal types in summaries.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1597893003: Don't include implicit initializing formal types in summaries. (Closed)

Created:
4 years, 11 months ago by Paul Berry

Modified:
4 years, 11 months ago

Reviewers:
scheglov

CC:
reviews_dartlang.org

Base URL:
git@github.com:dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

Don't include implicit initializing formal types in summaries. These can be easily inferred at resynthesis time. R=scheglov@google.com Committed: https://github.com/dart-lang/sdk/commit/2f99679042c548a97cb36a61462facae1cad03c6

Created: 4 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+57 lines, -32 lines)			Patch
M	pkg/analyzer/lib/src/summary/resynthesize.dart	View	7 chunks	+22 lines, -6 lines	0 comments	Download
M	pkg/analyzer/lib/src/summary/summarize_elements.dart	View	1 chunk	+16 lines, -10 lines	0 comments	Download
M	pkg/analyzer/test/src/summary/resynthesize_test.dart	View	3 chunks	+16 lines, -14 lines	0 comments	Download
M	pkg/analyzer/test/src/summary/summary_test.dart	View	2 chunks	+3 lines, -2 lines	0 comments	Download

Total messages: 5 (2 generated)

Paul Berry

4 years, 11 months ago (2016-01-17 17:12:12 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
2f99679042c548a97cb36a61462facae1cad03c6 (presubmit successful).