Add support for constrained windows on os x, based on Avi's GTMWindowSheetController.

Add support for constrained windows on os x, based on Avi's GTMWindowSheetController. Add carpet bombing dialog as first per-tab sheet.

Depends http://codereview.appspot.com/105064 .

The main issue with this patch is that GTMWindowSheetController doesn't provide an api to move sheets between windows, so this CL disables tab dragging for tabs with sheets, and fullscreen mode for windows with sheets. We can fix this later.

Other stuff that should be done at some point, but not now:

* Open/Save panels should be per-tab
* Need an ui test that goes to page, then page with sheet, then hit back, forward, reload.
* Bookmark sheets should not be sheets but in a separate window


BUG=14666
TEST=Go to skypher.com/SkyLined/Repro/Chrome/carpet bombing/repro.html , a per-window sheet should appear. Things to test with this dialog:

* Hitting cmd-q while a sheet is open in any tab should not quit but instead focus the sheet.

* Hitting cmd-w while a sheet is open in any tab should not close the window but instead focus the sheet.

* Dragging a tab with a sheet should move the window (and keep the tab visible), not detach the tab.

* Going fullscreen should be disabled for windows with open tabs.

* When a per-tab sheet is open in a non-active tab, it shouldn't steal the focus, i.e. going to the page above, then hitting cmd-t, and then hitting cmd-l should work.

* Closing a non-frontmost tab with a per-tab sheet shouldn't crash.

* Going to the url above and quickly opening a new tab, so that the sheet opens while its tab is not front-most should work (sheet should display only when you switch back to the tab with the sheet).

* Go to google.com, then to skypher.com/SkyLined/Repro/Chrome/carpet bombing/repro.html ,
  hit "backward" with open sheet, hit forward, focus location bar, hit enter. This shouldn't crash.

* Hitting escape should dismiss the sheet

* Hitting enter should confirm the sheet.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=23091

[Avi (use Gerrit), 2009-08-10 21:07:00]

Lotta nitpicking but overall it LGTM. Pink's out this week, BTW.

http://codereview.chromium.org/159780/diff/4026/4027
File base/scoped_nsobject.h (right):

http://codereview.chromium.org/159780/diff/4026/4027#newcode76
Line 76: // Specialization to make scoped_nsobject<id> work.
WIN

http://codereview.chromium.org/159780/diff/4026/4028
File chrome/browser/app_controller_mac.mm (right):

http://codereview.chromium.org/159780/diff/4026/4028#newcode116
Line 116: 
kill spare line

http://codereview.chromium.org/159780/diff/4026/4028#newcode140
Line 140: 
why the spaces?

http://codereview.chromium.org/159780/diff/4026/4028#newcode151
Line 151: 
ditto

http://codereview.chromium.org/159780/diff/4026/4028#newcode371
Line 371: 
ditto

http://codereview.chromium.org/159780/diff/4026/4031
File chrome/browser/cocoa/browser_window_controller.mm (right):

http://codereview.chromium.org/159780/diff/4026/4031#newcode214
Line 214: [window_ setWindowController:self];
is this not set in the nib? :(

http://codereview.chromium.org/159780/diff/4026/4031#newcode263
Line 263: 
space

http://codereview.chromium.org/159780/diff/4026/4031#newcode290
Line 290: 
space

http://codereview.chromium.org/159780/diff/4026/4031#newcode818
Line 818: 
space

http://codereview.chromium.org/159780/diff/4026/4033
File chrome/browser/cocoa/constrained_window_mac.mm (right):

http://codereview.chromium.org/159780/diff/4026/4033#newcode21
Line 21: [NSValue valueWithPointer:NULL],  // context info, passed to
didEndSelector.
80col

http://codereview.chromium.org/159780/diff/4026/4035
File chrome/browser/cocoa/download_request_dialog_delegate_mac.mm (right):

http://codereview.chromium.org/159780/diff/4026/4035#newcode82
Line 82: 
extra space

http://codereview.chromium.org/159780/diff/4026/4039
File chrome/browser/cocoa/tab_view.mm (right):

http://codereview.chromium.org/159780/diff/4026/4039#newcode163
Line 163: 
space

[Nico, 2009-08-10 23:56:41]

Thanks for the review, I've addressed all comments. The only thing missing is
the "how to programmatically close a sheet" thing. Should we go forward with the
explicit close call for now and document that it doesn't work for all system
sheets?

http://codereview.chromium.org/159780/diff/4026/4028
File chrome/browser/app_controller_mac.mm (right):

http://codereview.chromium.org/159780/diff/4026/4028#newcode116
Line 116: 
On 2009/08/10 21:07:00, Avi wrote:
> kill spare line

Done.

http://codereview.chromium.org/159780/diff/4026/4028#newcode140
Line 140: 
On 2009/08/10 21:07:00, Avi wrote:
> why the spaces?

Done. Java style is to force a newline after a function header that spans more
than one line. Old habits etc

http://codereview.chromium.org/159780/diff/4026/4031
File chrome/browser/cocoa/browser_window_controller.mm (right):

http://codereview.chromium.org/159780/diff/4026/4031#newcode214
Line 214: [window_ setWindowController:self];
On 2009/08/10 21:07:00, Avi wrote:
> is this not set in the nib? :(

It should be. I don't remember putting this here – removed it again. Things
still seem to work.

http://codereview.chromium.org/159780/diff/4026/4031#newcode263
Line 263: 
On 2009/08/10 21:07:00, Avi wrote:
> space

Done.

http://codereview.chromium.org/159780/diff/4026/4031#newcode290
Line 290: 
On 2009/08/10 21:07:00, Avi wrote:
> space

Done.

http://codereview.chromium.org/159780/diff/4026/4031#newcode818
Line 818: 
On 2009/08/10 21:07:00, Avi wrote:
> space

Done.

http://codereview.chromium.org/159780/diff/4026/4033
File chrome/browser/cocoa/constrained_window_mac.mm (right):

http://codereview.chromium.org/159780/diff/4026/4033#newcode21
Line 21: [NSValue valueWithPointer:NULL],  // context info, passed to
didEndSelector.
On 2009/08/10 21:07:00, Avi wrote:
> 80col

Done.

http://codereview.chromium.org/159780/diff/4026/4035
File chrome/browser/cocoa/download_request_dialog_delegate_mac.mm (right):

http://codereview.chromium.org/159780/diff/4026/4035#newcode82
Line 82: 
On 2009/08/10 21:07:00, Avi wrote:
> extra space

Done.

[Nico, 2009-08-11 03:29:13]

Hi Avi,

I've changed the constrained window stuff so that the delegate now explicitly
closes the sheet. This means no changes to GTMWindowSheetController are
required. Does this look good to you?

If so, I'd like to submit this. Pink can comment when he's back if he wants, but
I guess he will have quite a pile of stuff to go through and won't be mad if he
doesn't have to review this :-)

[Avi (use Gerrit), 2009-08-11 20:27:49]

LG

http://codereview.chromium.org/159780/diff/3145/3152
File chrome/browser/cocoa/constrained_window_mac.h (right):

http://codereview.chromium.org/159780/diff/3145/3152#newcode95
Line 95: // Contrained wiindows work slightly differently on OS X than on the
other
wiindows

http://codereview.chromium.org/159780/diff/3145/3152#newcode97
Line 97: // 1. A constrained window is bound to both a tab and window on os x.
OS X; match yourself five lines up.

http://codereview.chromium.org/159780/diff/3145/3152#newcode98
Line 98: // 2. The delegate is responsible for closing the sheet again when it
is deleted.
80col