Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1169)

Unified Diff: chrome/browser/cocoa/download_shelf_mac_unittest.mm

Issue 159776: Rewrites the Mac view resizing logic to have the BrowserWindowController... (Closed) Base URL: http://src.chromium.org/svn/trunk/src/
Patch Set: '' Created 11 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/cocoa/download_shelf_mac.mm ('k') | chrome/browser/cocoa/find_bar_cocoa_controller.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/cocoa/download_shelf_mac_unittest.mm
===================================================================
--- chrome/browser/cocoa/download_shelf_mac_unittest.mm (revision 22499)
+++ chrome/browser/cocoa/download_shelf_mac_unittest.mm (working copy)
@@ -57,19 +57,19 @@
BrowserTestHelper browser_helper_;
};
-TEST_F(DownloadShelfMacTest, CreationCallsShow) {
+TEST_F(DownloadShelfMacTest, CreationDoesNotCallShow) {
// Also make sure the DownloadShelfMacTest constructor doesn't crash.
DownloadShelfMac shelf(browser_helper_.browser(),
(DownloadShelfController*)shelf_controller_.get());
- EXPECT_EQ(1, shelf_controller_.get()->callCountShow);
+ EXPECT_EQ(0, shelf_controller_.get()->callCountShow);
}
TEST_F(DownloadShelfMacTest, ForwardsShow) {
DownloadShelfMac shelf(browser_helper_.browser(),
(DownloadShelfController*)shelf_controller_.get());
+ EXPECT_EQ(0, shelf_controller_.get()->callCountShow);
+ shelf.Show();
EXPECT_EQ(1, shelf_controller_.get()->callCountShow);
- shelf.Show();
- EXPECT_EQ(2, shelf_controller_.get()->callCountShow);
}
TEST_F(DownloadShelfMacTest, ForwardsHide) {
« no previous file with comments | « chrome/browser/cocoa/download_shelf_mac.mm ('k') | chrome/browser/cocoa/find_bar_cocoa_controller.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698