Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4860)

Unified Diff: chrome/browser/cocoa/bookmark_bar_bridge_unittest.mm

Issue 159776: Rewrites the Mac view resizing logic to have the BrowserWindowController... (Closed) Base URL: http://src.chromium.org/svn/trunk/src/
Patch Set: '' Created 11 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/app/nibs/InfoBarContainer.xib ('k') | chrome/browser/cocoa/bookmark_bar_controller.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/cocoa/bookmark_bar_bridge_unittest.mm
===================================================================
--- chrome/browser/cocoa/bookmark_bar_bridge_unittest.mm (revision 22499)
+++ chrome/browser/cocoa/bookmark_bar_bridge_unittest.mm (working copy)
@@ -32,15 +32,11 @@
@implementation FakeBookmarkBarController
-- (id)initWithProfile:(Profile*)profile
- parentView:(NSView*)parentView
- webContentView:(NSView*)webContentView
- infoBarsView:(NSView*)infoBarsView {
+- (id)initWithProfile:(Profile*)profile {
if ((self = [super initWithProfile:profile
- parentView:parentView
- webContentView:webContentView
- infoBarsView:infoBarsView
- delegate:self])) {
+ initialWidth:100 // arbitrary
+ resizeDelegate:nil
+ urlDelegate:self])) {
callbacks_.reset([[NSMutableArray alloc] init]);
}
return self;
@@ -96,14 +92,8 @@
class BookmarkBarBridgeTest : public testing::Test {
public:
- BookmarkBarBridgeTest() {
- NSRect content_frame = NSMakeRect(0, 0, 100, 100);
- view_.reset([[NSView alloc] initWithFrame:content_frame]);
- }
-
CocoaTestHelper cocoa_helper_;
BrowserTestHelper browser_test_helper_;
- scoped_nsobject<NSView> view_;
};
// Call all the callbacks; make sure they are all redirected to the objc object.
@@ -119,11 +109,7 @@
[[NSView alloc] initWithFrame:NSMakeRect(0,0,100,100)]);
scoped_nsobject<FakeBookmarkBarController>
- controller([[FakeBookmarkBarController alloc]
- initWithProfile:profile
- parentView:parentView.get()
- webContentView:webView.get()
- infoBarsView:infoBarsView.get()]);
+ controller([[FakeBookmarkBarController alloc] initWithProfile:profile]);
EXPECT_TRUE(controller.get());
scoped_ptr<BookmarkBarBridge> bridge(new BookmarkBarBridge(controller.get(),
model));
« no previous file with comments | « chrome/app/nibs/InfoBarContainer.xib ('k') | chrome/browser/cocoa/bookmark_bar_controller.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698