Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(854)

Unified Diff: chrome/browser/cocoa/infobar_container_controller_unittest.mm

Issue 159776: Rewrites the Mac view resizing logic to have the BrowserWindowController... (Closed) Base URL: http://src.chromium.org/svn/trunk/src/
Patch Set: '' Created 11 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/cocoa/infobar_container_controller.mm ('k') | chrome/browser/cocoa/toolbar_controller.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/cocoa/infobar_container_controller_unittest.mm
===================================================================
--- chrome/browser/cocoa/infobar_container_controller_unittest.mm (revision 22499)
+++ chrome/browser/cocoa/infobar_container_controller_unittest.mm (working copy)
@@ -7,44 +7,21 @@
#include "base/scoped_nsautorelease_pool.h"
#include "base/scoped_nsobject.h"
#include "chrome/browser/cocoa/browser_test_helper.h"
-#import "chrome/browser/cocoa/browser_window_controller.h"
#import "chrome/browser/cocoa/cocoa_test_helper.h"
#import "chrome/browser/cocoa/infobar_container_controller.h"
#include "chrome/browser/cocoa/infobar_test_helper.h"
+#import "chrome/browser/cocoa/view_resizer_pong.h"
#include "testing/gtest/include/gtest/gtest.h"
-// Objective-C classes must be defined outside the namespace.
-@interface BrowserWindowControllerPong : BrowserWindowController {
- BOOL pong_;
-}
-@property(readonly) BOOL pong;
-@end
-
-@implementation BrowserWindowControllerPong
-@synthesize pong = pong_;
-
-- (id)initWithBrowser:(Browser*)browser {
- if ((self = [super initWithBrowser:browser takeOwnership:NO])) {
- pong_ = NO;
- }
- return self;
-}
-
-- (void)infoBarResized:(float)newHeight {
- pong_ = TRUE;
-}
-@end
-
namespace {
class InfoBarContainerControllerTest : public testing::Test {
virtual void SetUp() {
- browserController_.reset([[BrowserWindowControllerPong alloc]
- initWithBrowser:browser_helper_.browser()]);
+ resizeDelegate_.reset([[ViewResizerPong alloc] init]);
TabStripModel* model = browser_helper_.browser()->tabstrip_model();
controller_.reset([[InfoBarContainerController alloc]
initWithTabStripModel:model
- browserWindowController:browserController_]);
+ resizeDelegate:resizeDelegate_.get()]);
}
public:
@@ -54,7 +31,7 @@
CocoaTestHelper cocoa_helper_;
BrowserTestHelper browser_helper_;
base::ScopedNSAutoreleasePool pool_;
- scoped_nsobject<BrowserWindowControllerPong> browserController_;
+ scoped_nsobject<ViewResizerPong> resizeDelegate_;
scoped_nsobject<InfoBarContainerController> controller_;
};
@@ -67,9 +44,11 @@
}
TEST_F(InfoBarContainerControllerTest, BWCPong) {
- // Call positionInfoBarsAndResize and check that the BWC got a resize message.
+ // Call positionInfoBarsAndResize and check that |resizeDelegate_| got a
+ // resize message.
+ [resizeDelegate_ setHeight:-1];
[controller_ positionInfoBarsAndRedraw];
- EXPECT_TRUE([browserController_ pong]);
+ EXPECT_NE(-1, [resizeDelegate_ height]);
}
TEST_F(InfoBarContainerControllerTest, AddAndRemoveInfoBars) {
« no previous file with comments | « chrome/browser/cocoa/infobar_container_controller.mm ('k') | chrome/browser/cocoa/toolbar_controller.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698