Rewrites the Mac view resizing logic to have the BrowserWindowController...

chrome/browser/cocoa/download_shelf_controller.mm

 // Copyright (c) 2009 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #import "chrome/browser/cocoa/download_shelf_controller.h"
 
 #include "app/l10n_util.h"
 #include "base/mac_util.h"
 #include "base/sys_string_conversions.h"
 #include "chrome/browser/browser.h"
@@ skipping 22 matching lines @@
 // Horizontal padding between two download items.
 const int kDownloadItemPadding = 10;
 
 // Duration for the open-new-leftmost-item animation, in seconds.
 const NSTimeInterval kDownloadItemOpenDuration = 0.8;
 
 }  // namespace
 
 @interface DownloadShelfController(Private)
 - (void)applyContentAreaOffset:(BOOL)apply;
-- (void)positionBar;
 - (void)showDownloadShelf:(BOOL)enable;
 - (void)resizeDownloadLinkToFit;
 @end
 
 
 @implementation DownloadShelfController
 
 - (id)initWithBrowser:(Browser*)browser
-          contentArea:(NSView*)content {
+       resizeDelegate:(id<ViewResizer>)resizeDelegate {
   if ((self = [super initWithNibName:@"DownloadShelf"
                               bundle:mac_util::MainAppBundle()])) {
-    contentArea_ = content;
+    resizeDelegate_ = resizeDelegate;
     shelfHeight_ = [[self view] bounds].size.height;
 
-    [self positionBar];
-    [[[contentArea_ window] contentView] addSubview:[self view]];
+    // Reset the download shelf's frame to zero.  It will be properly positioned
+    // and sized the first time we try to set its height.
+    [[self view] setFrame:NSZeroRect];
 
     downloadItemControllers_.reset([[NSMutableArray alloc] init]);
 
     // This calls show:, so it needs to be last.
     bridge_.reset(new DownloadShelfMac(browser, self));
   }
   return self;
 }
 
 - (void)awakeFromNib {
@@ skipping 59 matching lines @@
   [itemContainerView_ setNeedsDisplay:YES];
 }
 
 - (BOOL)textView:(NSTextView *)aTextView
    clickedOnLink:(id)link
          atIndex:(NSUInteger)charIndex {
   bridge_->browser()->ShowDownloadsTab();
   return YES;
 }
 
-// Initializes the download shelf at the bottom edge of |contentArea_|.
-- (void)positionBar {
-  // Set the bar's height to zero and position it at the bottom of the content
-  // area, within the window's content view (as opposed to the tab strip, which
-  // is a sibling). We'll enlarge it and slide the content area up when we need
-  // to show this strip.
-  NSRect contentFrame = [contentArea_ frame];
-  NSRect barFrame = NSMakeRect(0, 0, contentFrame.size.width, shelfHeight_);
-  [[self view] setFrame:barFrame];
-}
-
-// Called when the contentArea's frame changes.  Enlarge the view to stay with
-// the bottom of the contentArea.
-- (void)resizeDownloadShelf {
-  NSRect barFrame = [[self view] frame];
-  barFrame.origin.y = 0;
-  barFrame.size.height = NSMinY([contentArea_ frame]);
-  [[self view] setFrame:barFrame];
-}
-
 - (void)remove:(DownloadItemController*)download {
   // Look for the download in our controller array and remove it. This will
   // explicity release it so that it removes itself as an Observer of the
   // DownloadItem. We don't want to wait for autorelease since the DownloadItem
   // we are observing will likely be gone by then.
   [[NSNotificationCenter defaultCenter] removeObserver:download];
   [[download view] removeFromSuperview];
   [downloadItemControllers_ removeObject:download];
 
   // TODO(thakis): Need to relayout the remaining item views here (
   // crbug.com/17831 ).
 
   // Check to see if we have any downloads remaining and if not, hide the shelf.
   if (![downloadItemControllers_ count])
     [self showDownloadShelf:NO];
 }
 
 // We need to explicitly release our download controllers here since they need
 // to remove themselves as observers before the remaining shutdown happens.
 - (void)exiting {
   downloadItemControllers_.reset();
 }
 
 // Show or hide the bar based on the value of |enable|. Handles animating the
 // resize of the content view.
 - (void)showDownloadShelf:(BOOL)enable {
   if ([self isVisible] == enable)
     return;
 
-  contentAreaHasOffset_ = enable;
-  [[self view] setHidden:enable ? NO : YES];
-  [self applyContentAreaOffset:enable];
-
+  [resizeDelegate_ resizeView:[self view]
+                    newHeight:(enable ? shelfHeight_ : 0)];
   barIsVisible_ = enable;
 }
 
-// Apply a contents box offset to make (or remove) room for the download shelf.
-// If apply is YES, always make room (the contentView_ is "full size"). If apply
-// is NO, we are trying to undo an offset. If no offset there is nothing to undo.
-- (void)applyContentAreaOffset:(BOOL)apply {
-  if (!contentAreaHasOffset_ && apply) {
-    // There is no offset to unconditionally apply.
-    return;
-  }
-
-  NSRect frame = [contentArea_ frame];
-  if (apply) {
-    frame.origin.y += shelfHeight_;
-    frame.size.height -= shelfHeight_;
-  } else {
-    frame.origin.y -= shelfHeight_;
-    frame.size.height += shelfHeight_;
-  }
-
-  [[contentArea_ animator] setFrame:frame];
-  [[self view] setNeedsDisplay:YES];
-  [contentArea_ setNeedsDisplay:YES];
-}
-
 - (DownloadShelf*)bridge {
   return bridge_.get();
 }
 
 - (BOOL)isVisible {
   return barIsVisible_;
 }
 
 - (void)show:(id)sender {
   [self showDownloadShelf:YES];
@@ skipping 61 matching lines @@
     DCHECK(kMaxDownloadItemCount > 0);
 
     // Since no user will ever see the item being removed (needs a horizontal
     // screen resolution greater than 3200 at 16 items at 200 pixels each),
     // there's no point in animating the removal.
     [self remove:[downloadItemControllers_ objectAtIndex:0]];
   }
 }
 
 @end