Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5528)

Unified Diff: chrome/browser/resources/about_invalidations.html

Issue 159773006: [invalidations] Added table with registered objectsIds (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@about_invalidations_clean
Patch Set: Nits and simplified the JS with <thead> Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/resources/about_invalidations.css ('k') | chrome/browser/resources/about_invalidations.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/resources/about_invalidations.html
diff --git a/chrome/browser/resources/about_invalidations.html b/chrome/browser/resources/about_invalidations.html
index d7dd623dd0b8741f10617b213f18113b0a3dae56..0dba8abe2420ab367641052332999d22ccfe68fa 100644
--- a/chrome/browser/resources/about_invalidations.html
+++ b/chrome/browser/resources/about_invalidations.html
@@ -13,17 +13,42 @@
<h1>Invalidations Debug Information</h1>
<div id="invalidations-info">
<div id="states" class="section">
- <label>
- <p>Invalidation service state:</p><span id="invalidations-state"></span>
- </label>
+ <span class='lead'>Invalidation service state:</span>
+ <span id="invalidations-state"></span>
+ </div>
+ <div id="objectsid-table-div" class="section">
+ <span class='lead'>Registered objectsIds for invalidations:</span>
+ <table id="objectsid-table-container">
+ <!-- 'objectsidtable' can't have dashes in the name
+ as jstemplate can't deal with them-->
+ <thead>
+ <tr class="header">
+ <td>Registrar</td>
rlarocque 2014/02/15 01:35:18 I think <th> would be more appropriate.
mferreria_g 2014/02/15 01:54:44 Agree. Done.
+ <td>Source</td>
+ <td>Name</td>
+ <td>Count</td>
+ <td>Version</td>
+ <td>Time</td>
+ <td>Last Payload</td>
+ </tr>
+ </thead>
+ <tr jsselect="objectsidtable" jsvalues="class:$this.type">
rlarocque 2014/02/15 01:35:18 There's a <tbody> element, too. I'd be surprised
mferreria_g 2014/02/15 01:54:44 Done. No effect, but made it a bit more HTML compl
+ <td jscontent="registrar" width=5%></td>
+ <td jscontent="source" width=5%></td>
+ <td jscontent="name" width=20%></td>
+ <td jscontent="count" width=5%></td>
+ <td jscontent="version" width=10%></td>
+ <td jscontent="time" width=20%></td>
+ <td jscontent="payload" width=35%></td>
+ </tr>
+ </table>
</div>
<div class="section">
- <label>
- <p>Invalidations Log:</p>
- <textarea
- id="invalidations-log" rows="10" cols="120" readonly></textarea>
- </label>
+ <span class='lead'>Invalidations Log:</span>
+ <textarea
+ id="invalidations-log" rows="10" cols="120"readonly></textarea>
</div>
</div>
+ <script src="chrome://resources/js/jstemplate_compiled.js"></script>
</body>
</html>
« no previous file with comments | « chrome/browser/resources/about_invalidations.css ('k') | chrome/browser/resources/about_invalidations.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698