Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(313)

Unified Diff: chrome/browser/signin/oauth2_token_service.cc

Issue 15977002: Add ManagedUserTokenFetcher to fetch scoped-down tokens. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: review Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/signin/oauth2_token_service.cc
diff --git a/chrome/browser/signin/oauth2_token_service.cc b/chrome/browser/signin/oauth2_token_service.cc
index abddb4e8d46ba4b2febc36111848eddc313f8858..8e13d3844b10813377d3648612589ce44e6ef662 100644
--- a/chrome/browser/signin/oauth2_token_service.cc
+++ b/chrome/browser/signin/oauth2_token_service.cc
@@ -303,18 +303,6 @@ bool OAuth2TokenService::RefreshTokenIsAvailable() {
return !GetRefreshToken().empty();
}
-// static
-void OAuth2TokenService::InformConsumer(
- base::WeakPtr<OAuth2TokenService::RequestImpl> request,
- const GoogleServiceAuthError& error,
- const std::string& access_token,
- const base::Time& expiration_date) {
- DCHECK(content::BrowserThread::CurrentlyOn(content::BrowserThread::UI));
-
- if (request)
- request->InformConsumer(error, access_token, expiration_date);
-}
-
scoped_ptr<OAuth2TokenService::Request> OAuth2TokenService::StartRequest(
const OAuth2TokenService::ScopeSet& scopes,
OAuth2TokenService::Consumer* consumer) {
@@ -325,7 +313,7 @@ scoped_ptr<OAuth2TokenService::Request> OAuth2TokenService::StartRequest(
std::string refresh_token = GetRefreshToken();
if (refresh_token.empty()) {
MessageLoop::current()->PostTask(FROM_HERE, base::Bind(
- &OAuth2TokenService::InformConsumer,
+ &RequestImpl::InformConsumer,
request->AsWeakPtr(),
GoogleServiceAuthError(
GoogleServiceAuthError::USER_NOT_SIGNED_UP),
@@ -361,7 +349,7 @@ scoped_ptr<OAuth2TokenService::Request>
const CacheEntry* cache_entry = GetCacheEntry(scopes);
scoped_ptr<RequestImpl> request(new RequestImpl(consumer));
MessageLoop::current()->PostTask(FROM_HERE, base::Bind(
- &OAuth2TokenService::InformConsumer,
+ &RequestImpl::InformConsumer,
request->AsWeakPtr(),
GoogleServiceAuthError(GoogleServiceAuthError::NONE),
cache_entry->access_token,
@@ -440,7 +428,7 @@ bool OAuth2TokenService::RemoveCacheEntry(
const std::string& token_to_remove) {
DCHECK(content::BrowserThread::CurrentlyOn(content::BrowserThread::UI));
TokenCache::iterator token_iterator = token_cache_.find(scopes);
- if (token_iterator == token_cache_.end() &&
+ if (token_iterator != token_cache_.end() &&
token_iterator->second.access_token == token_to_remove) {
token_cache_.erase(token_iterator);
return true;

Powered by Google App Engine
This is Rietveld 408576698