Add ManagedUserTokenFetcher to fetch scoped-down tokens.

google_apis/gaia/gaia_oauth_client.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "google_apis/gaia/gaia_oauth_client.h"
 
 #include "base/json/json_reader.h"
 #include "base/logging.h"
 #include "base/memory/scoped_ptr.h"
 #include "base/values.h"
@@ skipping 185 matching lines @@
         message_value->IsType(Value::TYPE_DICTIONARY)) {
       response_dict.reset(
           static_cast<DictionaryValue*>(message_value.release()));
     }
   }
 
   if (!response_dict.get()) {
     // If we don't have an access token yet and the the error was not
     // RC_BAD_REQUEST, we may need to retry.
     if ((source->GetMaxRetriesOn5xx() != -1) &&
-        (num_retries_ > source->GetMaxRetriesOn5xx())) {
+        (num_retries_ >= source->GetMaxRetriesOn5xx())) {

[Andrew T Wilson (Slow), 2013/05/27 13:52:15]

Do we have a test that exercises this change?

[Bernhard Bauer, 2013/05/27 14:42:13]

device_cloud_policy_manager_chromeos_unittest.cc (which used to work around the
off-by-one error here), and also
ManagedUserTokenFetcherTest.FetchRefreshTokenTransientNetworkError, which tests
that the number of retries is correct.

       // Retry limit reached. Give up.
       delegate_->OnNetworkError(source->GetResponseCode());
     } else {
       request_ = old_request.Pass();
       *should_retry_request = true;
     }
     return;
   }
 
   RequestType type = request_type_;
@@ skipping 65 matching lines @@
                              delegate);
 }
 
 void GaiaOAuthClient::GetUserInfo(const std::string& access_token,
                                   int max_retries,
                                   Delegate* delegate) {
   return core_->GetUserInfo(access_token, max_retries, delegate);
 }
 
 }  // namespace gaia