Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(207)

Issue 159769: Allow cancellable download items to be removable from download shelf.... (Closed)

Created:
11 years, 4 months ago by Mohamed Mansour
Modified:
9 years, 6 months ago
Reviewers:
sky
CC:
chromium-reviews_googlegroups.com, Paul Godavari, Ben Goodger (Google)
Visibility:
Public.

Description

Allow cancellable download items to be removable from download shelf. BUG=18235 (http://crbug.com/18235) TEST=Cancel a big download and remove it. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=22276

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Patch Set 4 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M chrome/browser/download/download_shelf.cc View 1 2 3 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
Mohamed Mansour
Please review, one line change that allows cancelable download items to be removed. Previously, it ...
11 years, 4 months ago (2009-08-02 04:13:24 UTC) #1
sky
11 years, 4 months ago (2009-08-03 15:32:00 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698