Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(336)

Issue 159767: When a content script has a match pattern of http://*/*, we (Closed)

Created:
11 years, 4 months ago by Aaron Boodman
Modified:
9 years, 6 months ago
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

When a content script has a match pattern of http://*/*, we should run on web pages that have an IP address for their host. BUG=18256 TEST=Added unit test Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=22260

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -5 lines) Patch
M chrome/common/extensions/url_pattern.cc View 1 chunk +13 lines, -5 lines 0 comments Download
M chrome/common/extensions/url_pattern_unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Aaron Boodman
11 years, 4 months ago (2009-08-02 02:44:56 UTC) #1
Erik does not do reviews
11 years, 4 months ago (2009-08-02 14:32:26 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698