Issue 159766: Hunspell 1.2.8 caused valgrind warnings

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 159766: Hunspell 1.2.8 caused valgrind warnings (Closed)

Created:
11 years, 4 months ago by Mohamed Mansour

Modified:
9 years, 6 months ago

Reviewers:
dank

CC:
chromium-reviews_googlegroups.com, not_the_right_glider, stuartmorgan, dank, the_wrong_timurrrr, Nirnimesh

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Hunspell 1.2.8 update caused valgrind warnings. BUG=18254 TEST=None Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=22252

Patch Set 1 #

Created: 11 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -0 lines)			Patch
	M	chrome/test/data/valgrind/unit_tests.gtest.txt	View		1 chunk	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

not_the_right_dank

11 years, 4 months ago (2009-08-02 14:28:44 UTC) #2

LGTM

On Sat, Aug 1, 2009 at 7:16 PM, <mhm@chromium.org> wrote:
>
> Reviewers: dank,
>
> Description:
> Hunspell 1.2.8 caused 28 suppressions within valgrind
>
> BUG=3D18254
> TEST=3DNone
>
>
> Please review this at http://codereview.chromium.org/159766
>
> SVN Base: svn://svn.chromium.org/chrome/trunk/src/
>
> Affected files:
> =A0M =A0 =A0 chrome/test/data/valgrind/unit_tests.gtest.txt
>
>
> Index: chrome/test/data/valgrind/unit_tests.gtest.txt
> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
> --- chrome/test/data/valgrind/unit_tests.gtest.txt =A0 =A0 =A0(revision 2=
2243)
> +++ chrome/test/data/valgrind/unit_tests.gtest.txt =A0 =A0 =A0(working co=
py)
> @@ -1,2 +1,4 @@
> =A0# Takes 65 seconds to run.
> =A0IPCSyncChannelTest.ChattyServer
> +# Bug18254 - Hunspell 1.2.8 caused 28 suppression.
> +SpellCheckTest.SpellCheckSuggestions_EN_US
>
>
>

Expand Messages | Collapse Messages