components/browser_context_keyed_service/browser_context_dependency_manager.cc - Issue 159763004: Eliminate potential for flaky crash in BCKSFactory::SetTestingFactory().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/browser_context_keyed_service/browser_context_dependency_manager.cc

Issue 159763004: Eliminate potential for flaky crash in BCKSFactory::SetTestingFactory(). (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/browser_context_keyed_service/browser_context_dependency_manager.h ('k') | components/browser_context_keyed_service/browser_context_keyed_base_factory.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/browser_context_keyed_service/browser_context_dependency_manager.cc

diff --git a/components/browser_context_keyed_service/browser_context_dependency_manager.cc b/components/browser_context_keyed_service/browser_context_dependency_manager.cc

index 913c92b80858a7f4489bb486e84cf0ab874dfdef..a7b66be0adac8f66800fc655f8f350a67323f1ea 100644

--- a/components/browser_context_keyed_service/browser_context_dependency_manager.cc

+++ b/components/browser_context_keyed_service/browser_context_dependency_manager.cc

@@ -139,6 +139,11 @@ void BrowserContextDependencyManager::AssertBrowserContextWasntDestroyed(

<< "services again.";

}

+void BrowserContextDependencyManager::MarkBrowserContextLiveForTesting(

+ content::BrowserContext* context) {

+ dead_context_pointers_.erase(context);

#endif

// static