Eliminate potential for flaky crash in BCKSFactory::SetTestingFactory().

components/browser_context_keyed_service/browser_context_dependency_manager.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef COMPONENTS_BROWSER_CONTEXT_KEYED_SERVICE_BROWSER_CONTEXT_DEPENDENCY_MANAGER_H_
 #define COMPONENTS_BROWSER_CONTEXT_KEYED_SERVICE_BROWSER_CONTEXT_DEPENDENCY_MANAGER_H_
 
 #include "base/memory/singleton.h"
 #include "components/browser_context_keyed_service/browser_context_keyed_service_export.h"
 #include "components/browser_context_keyed_service/dependency_graph.h"
@@ skipping 50 matching lines @@
 
   // Called by each BrowserContext to alert us that we should destroy services
   // associated with it.
   void DestroyBrowserContextServices(content::BrowserContext* context);
 
 #ifndef NDEBUG
   // Debugging assertion called as part of GetServiceForBrowserContext in debug
   // mode. This will NOTREACHED() whenever the user is trying to access a stale
   // BrowserContext*.
   void AssertBrowserContextWasntDestroyed(content::BrowserContext* context);
+
+  // Marks |context| as live (i.e., not stale). This method can be called as a
+  // safeguard against |AssertBrowserContextWasntDestroyed()| checks going off
+  // due to |context| aliasing a BrowserContext instance from a prior test
+  // (i.e., 0xWhatever might be created, be destroyed, and then a new
+  // BrowserContext object might be created at 0xWhatever).
+  void MarkBrowserContextLiveForTesting(content::BrowserContext* context);
 #endif
 
   static BrowserContextDependencyManager* GetInstance();
 
  private:
   friend class BrowserContextDependencyManagerUnittests;
   friend struct DefaultSingletonTraits<BrowserContextDependencyManager>;
 
   // Helper function used by CreateBrowserContextServices[ForTest].
   void DoCreateBrowserContextServices(content::BrowserContext* context,
@@ skipping 11 matching lines @@
 #ifndef NDEBUG
   // A list of context objects that have gone through the Shutdown()
   // phase. These pointers are most likely invalid, but we keep track of their
   // locations in memory so we can nicely assert if we're asked to do anything
   // with them.
   std::set<content::BrowserContext*> dead_context_pointers_;
 #endif
 };
 
 #endif  // COMPONENTS_BROWSER_CONTEXT_KEYED_SERVICE_BROWSER_CONTEXT_DEPENDENCY_MANAGER_H_