Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1700)

Issue 1597603002: Revert of libxml2: linearly optimize XPath expressions. (Closed)

Created:
4 years, 11 months ago by jsbell
Modified:
4 years, 11 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of libxml2: linearly optimize XPath expressions. (patchset #4 id:60001 of https://codereview.chromium.org/1562133002/ ) Reason for revert: MSAN failure - use of uninitialized value. Original issue's description: > libxml2: linearly optimize XPath expressions. > > Some XPath expression nodes keep a back pointer to the last/previous > expression node for optimization purposes. Such pointers will result > in repeated work when walking over the expression > tree/graph, peephole optimizing it. Unacceptable amounts of repeated > work as the expression tree becomes deeper. > > Avoid by marking the expression nodes during the optimization pass. > > R=scottmg > BUG=573768 > > Committed: https://crrev.com/0b208a502be9d60929be48056dd4213efd998076 > Cr-Commit-Position: refs/heads/master@{#369733} TBR=scottmg@chromium.org,cpu@chromium.org,thakis@chromium.org,sigbjornf@opera.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=573768 Committed: https://crrev.com/3d68bdb9bd3c12b59b816a65a84741dccb9fa0c1 Cr-Commit-Position: refs/heads/master@{#369806}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -26 lines) Patch
M third_party/libxml/README.chromium View 2 chunks +2 lines, -1 line 0 comments Download
M third_party/libxml/src/xpath.c View 4 chunks +6 lines, -25 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
jsbell
Created Revert of libxml2: linearly optimize XPath expressions.
4 years, 11 months ago (2016-01-15 19:17:41 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1597603002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1597603002/1
4 years, 11 months ago (2016-01-15 19:19:51 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-15 19:22:13 UTC) #3
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/3d68bdb9bd3c12b59b816a65a84741dccb9fa0c1 Cr-Commit-Position: refs/heads/master@{#369806}
4 years, 11 months ago (2016-01-15 19:23:22 UTC) #5
sof
4 years, 11 months ago (2016-01-15 20:44:52 UTC) #6
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698