Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(390)

Issue 159753008: Disable Me2Me host controls on unsupported Linux systems. (Closed)

Created:
6 years, 10 months ago by Sergey Ulanov
Modified:
6 years, 10 months ago
Reviewers:
Lambros, Jamie
CC:
chromium-reviews, chromoting-reviews_chromium.org
Visibility:
Public.

Description

Disable Me2Me host controls on unsupported Linux systems. Currently a system is considered to be supported in three cases: 1. ~/.chrome-remote-desktop-session file exists. 2. ~/.config/chrome-remote-desktop directory exists. 3. DISTRIB_ID=Ubuntu is set in /etc/lsb-release BUG=149744 R=lambroslambrou@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=251485

Patch Set 1 : #

Total comments: 1

Patch Set 2 : #

Total comments: 4

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+61 lines, -10 lines) Patch
M remoting/host/setup/daemon_controller_delegate_linux.cc View 2 chunks +29 lines, -7 lines 0 comments Download
M remoting/tools/me2me_virtual_host.py View 1 2 6 chunks +30 lines, -2 lines 0 comments Download
M remoting/webapp/host_list.js View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 10 (0 generated)
Sergey Ulanov
https://codereview.chromium.org/159753008/diff/30001/remoting/webapp/host_list.js File remoting/webapp/host_list.js (right): https://codereview.chromium.org/159753008/diff/30001/remoting/webapp/host_list.js#newcode310 remoting/webapp/host_list.js:310: state != remoting.HostController.State.UNKNOWN) && This is not essential for ...
6 years, 10 months ago (2014-02-12 01:35:35 UTC) #1
Lambros
lgtm with comments https://codereview.chromium.org/159753008/diff/50001/remoting/tools/me2me_virtual_host.py File remoting/tools/me2me_virtual_host.py (right): https://codereview.chromium.org/159753008/diff/50001/remoting/tools/me2me_virtual_host.py#newcode56 remoting/tools/me2me_virtual_host.py:56: CONFIG_DIR = HOME_DIR + "/.config/chrome-remote-desktop" Use ...
6 years, 10 months ago (2014-02-12 20:50:32 UTC) #2
Sergey Ulanov
https://codereview.chromium.org/159753008/diff/50001/remoting/tools/me2me_virtual_host.py File remoting/tools/me2me_virtual_host.py (right): https://codereview.chromium.org/159753008/diff/50001/remoting/tools/me2me_virtual_host.py#newcode56 remoting/tools/me2me_virtual_host.py:56: CONFIG_DIR = HOME_DIR + "/.config/chrome-remote-desktop" On 2014/02/12 20:50:32, Lambros ...
6 years, 10 months ago (2014-02-13 02:25:44 UTC) #3
Sergey Ulanov
The CQ bit was checked by sergeyu@chromium.org
6 years, 10 months ago (2014-02-13 02:25:57 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sergeyu@chromium.org/159753008/110001
6 years, 10 months ago (2014-02-13 02:26:43 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-13 04:16:31 UTC) #6
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) app_list_unittests, ash_unittests, aura_unittests, cacheinvalidation_unittests, cc_unittests, check_deps, ...
6 years, 10 months ago (2014-02-13 04:16:31 UTC) #7
Sergey Ulanov
The CQ bit was checked by sergeyu@chromium.org
6 years, 10 months ago (2014-02-15 01:50:26 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sergeyu@chromium.org/159753008/110001
6 years, 10 months ago (2014-02-15 01:51:30 UTC) #9
Sergey Ulanov
6 years, 10 months ago (2014-02-15 03:11:15 UTC) #10
Message was sent while issue was closed.
Committed patchset #3 manually as r251485 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698