Replace sets with vectors when storing file handlers.

chrome/browser/chromeos/extensions/file_manager/file_browser_handler.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/chromeos/extensions/file_manager/file_browser_handler.h"
 
 #include "base/logging.h"
 #include "base/string_util.h"
 #include "base/strings/string_number_conversions.h"
 #include "base/utf_string_conversions.h"
@@ skipping 164 matching lines @@
         return NULL;
       }
     }
   }
   if (!result->ValidateFileAccessPermissions()) {
     *error = ASCIIToUTF16(errors::kInvalidFileAccessList);
     return NULL;
   }
 
   // Initialize file filters (mandatory, unless "create" access is specified,
-  // in which case is ignored).
+  // in which case is ignored). The list can be empty.
   if (!result->HasCreateAccessPermission()) {
     const ListValue* file_filters = NULL;
     if (!file_browser_handler->HasKey(keys::kFileFilters) ||
-        !file_browser_handler->GetList(keys::kFileFilters, &file_filters) ||
-        file_filters->empty()) {

[hashimoto, 2013/05/24 11:15:51]

You are going to change the behavior of a public API.
(http://developer.chrome.com/extensions/fileBrowserHandler.html)
I don't think allowing empty file filters as an alternative to "filesystem:*" is
a good idea, can't we go as strict as possible?

[mtomasz, 2013/05/27 01:20:20]

I don't think it changes the api. This change allows an empty list, which is not
forbidden in the provided link.

Empty filter list means that this handler does handle any specific files. It is
used internally only.

+        !file_browser_handler->GetList(keys::kFileFilters, &file_filters)) {
       *error = ASCIIToUTF16(errors::kInvalidFileFiltersList);
       return NULL;
     }
     for (size_t i = 0; i < file_filters->GetSize(); ++i) {
       std::string filter;
       if (!file_filters->GetString(i, &filter)) {
         *error = extensions::ErrorUtils::FormatErrorMessageUTF16(
             errors::kInvalidFileFilterValue, base::IntToString(i));
         return NULL;
       }
@@ skipping 83 matching lines @@
     return false;  // Failed to parse file browser actions definition.
   }
 
   extension->SetManifestData(keys::kFileBrowserHandlers, info.release());
   return true;
 }
 
 const std::vector<std::string> FileBrowserHandlerParser::Keys() const {
   return SingleKey(keys::kFileBrowserHandlers);
 }