Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Issue 1597403002: X87: [turbofan] Add the RoundInt32ToFloat32 operator to turbofan. (Closed)

Created:
4 years, 11 months ago by zhengxing.li
Modified:
4 years, 11 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

X87: [turbofan] Add the RoundInt32ToFloat32 operator to turbofan. port e06f7d784e7a6f948ecc02ff1725578b9e9f0bda (r33347) original commit message: The new operator converts an int32 input to float32. If the input cannot be represented exactly in float32, the value is rounded using the round-ties-even rounding mode (the default rounding mode). I provide implementations of the new operator for x64, ia32, arm, arm64, mips, mips64, ppc, and ppc64. BUG= Committed: https://crrev.com/30bcfba3f7fd3ebe059bd1d43952f3e3be79c1d2 Cr-Commit-Position: refs/heads/master@{#33351}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -1 line) Patch
M src/compiler/x87/code-generator-x87.cc View 1 chunk +14 lines, -0 lines 0 comments Download
M src/compiler/x87/instruction-codes-x87.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/x87/instruction-selector-x87.cc View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
zhengxing.li
PTAL, thanks!
4 years, 11 months ago (2016-01-18 06:05:33 UTC) #2
Weiliang
lgtm
4 years, 11 months ago (2016-01-18 06:24:34 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1597403002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1597403002/1
4 years, 11 months ago (2016-01-18 08:21:32 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-18 08:39:45 UTC) #6
commit-bot: I haz the power
4 years, 11 months ago (2016-01-18 08:40:06 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/30bcfba3f7fd3ebe059bd1d43952f3e3be79c1d2
Cr-Commit-Position: refs/heads/master@{#33351}

Powered by Google App Engine
This is Rietveld 408576698