Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(337)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 15974008: Rename SessionStateController -> LockStateController (Closed)

Created:
7 years, 6 months ago by Nikita (slow)
Modified:
7 years, 6 months ago
CC:
chromium-reviews, sadrul, nkostylev+watch_chromium.org, ben+watch_chromium.org, oshima+watch_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org
Visibility:
Public.

Description

Rename SessionStateController -> LockStateController. Now that we have SessionStateDelegate which covers more aspects of the session than just lock/unlock/shut down animations makes sense to rename lock animation related classes. SessionStateController -> LockStateController SessionStateControllerImpl2 > LockStateControllerImpl2 SessionStateObserver > LockStateObserver SessionStateObserver will be used as observer for SessionStateDelegate for things like active user changed etc. NOT renaming SessionStateControllerImpl since it is a legacy implementation and will removed soon. BUG=180903 NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=203193

Patch Set 1 : . #

Total comments: 3

Patch Set 2 : r #

Patch Set 3 : add files #

Patch Set 4 : . #

Patch Set 5 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+305 lines, -2510 lines) Patch
M ash/ash.gyp View 1 3 chunks +6 lines, -6 lines 0 comments Download
M ash/shell.h View 1 3 chunks +4 lines, -4 lines 0 comments Download
M ash/shell.cc View 1 3 chunks +7 lines, -7 lines 0 comments Download
A + ash/wm/lock_state_controller.h View 1 2 4 chunks +22 lines, -22 lines 0 comments Download
A + ash/wm/lock_state_controller.cc View 1 2 2 chunks +12 lines, -13 lines 0 comments Download
A + ash/wm/lock_state_controller_impl2.h View 1 2 7 chunks +17 lines, -17 lines 0 comments Download
A + ash/wm/lock_state_controller_impl2.cc View 1 2 25 chunks +67 lines, -65 lines 0 comments Download
A + ash/wm/lock_state_controller_impl2_unittest.cc View 1 2 31 chunks +60 lines, -61 lines 0 comments Download
A + ash/wm/lock_state_observer.h View 1 2 3 4 2 chunks +7 lines, -7 lines 0 comments Download
M ash/wm/power_button_controller.h View 1 2 chunks +3 lines, -3 lines 0 comments Download
M ash/wm/power_button_controller.cc View 1 1 chunk +3 lines, -2 lines 0 comments Download
M ash/wm/power_button_controller_unittest.cc View 1 28 chunks +57 lines, -58 lines 0 comments Download
D ash/wm/session_state_controller.h View 1 chunk +0 lines, -146 lines 0 comments Download
D ash/wm/session_state_controller.cc View 1 chunk +0 lines, -53 lines 0 comments Download
M ash/wm/session_state_controller_impl.h View 1 3 chunks +4 lines, -3 lines 0 comments Download
M ash/wm/session_state_controller_impl.cc View 1 4 chunks +8 lines, -10 lines 0 comments Download
D ash/wm/session_state_controller_impl2.h View 1 chunk +0 lines, -263 lines 0 comments Download
D ash/wm/session_state_controller_impl2.cc View 1 chunk +0 lines, -644 lines 0 comments Download
D ash/wm/session_state_controller_impl2_unittest.cc View 1 chunk +0 lines, -1071 lines 0 comments Download
D ash/wm/session_state_observer.h View 1 chunk +0 lines, -28 lines 0 comments Download
M ash/wm/toplevel_window_event_handler_unittest.cc View 1 2 3 4 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/chromeos/login/screen_locker.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/login/webui_screen_locker.h View 1 3 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/chromeos/login/webui_screen_locker.cc View 1 4 chunks +9 lines, -8 lines 0 comments Download
M chrome/browser/chromeos/power/power_button_observer.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/power/session_state_controller_delegate_chromeos.h View 1 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/system/ash_system_tray_delegate.cc View 1 2 3 4 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/chromeos/login/signin_screen_handler.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Nikita (slow)
This is just a mechanical rename to keep SessionStateDelegate and SessionLockState[Controller|Observer] separate plus add SessionStateObserver ...
7 years, 6 months ago (2013-05-30 13:15:03 UTC) #1
Nikita (slow)
https://codereview.chromium.org/15974008/diff/2001/ash/wm/toplevel_window_event_handler_unittest.cc File ash/wm/toplevel_window_event_handler_unittest.cc (right): https://codereview.chromium.org/15974008/diff/2001/ash/wm/toplevel_window_event_handler_unittest.cc#newcode476 ash/wm/toplevel_window_event_handler_unittest.cc:476: static_cast<SessionLockStateControllerImpl2*> I fixed static_cast which seems to be incorrect ...
7 years, 6 months ago (2013-05-30 13:16:10 UTC) #2
Daniel Erat
LGTM Do you think that the "session" in "SessionLockStateController" is necessary? If not, "LockStateController" would ...
7 years, 6 months ago (2013-05-30 14:53:29 UTC) #3
Denis Kuznetsov (DE-MUC)
lgtm
7 years, 6 months ago (2013-05-30 15:55:28 UTC) #4
Nikita (slow)
Dropped "Session" as well. https://codereview.chromium.org/15974008/diff/2001/ash/ash.gyp File ash/ash.gyp (right): https://codereview.chromium.org/15974008/diff/2001/ash/ash.gyp#newcode415 ash/ash.gyp:415: 'wm/session_lock_state_controller.cc', On 2013/05/30 14:53:30, Daniel ...
7 years, 6 months ago (2013-05-30 17:47:02 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nkostylev@chromium.org/15974008/14030
7 years, 6 months ago (2013-05-30 19:07:17 UTC) #6
commit-bot: I haz the power
7 years, 6 months ago (2013-05-30 19:07:50 UTC) #7
Message was sent while issue was closed. 
Change committed as 203193

Powered by Google App Engine
This is Rietveld 408576698