src/api.cc - Issue 15974006: Transforming PersistentHandleVisitor to not need to copy Persistent handles.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/api.cc

Issue 15974006: Transforming PersistentHandleVisitor to not need to copy Persistent handles. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Created 7 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/api.cc

diff --git a/src/api.cc b/src/api.cc

index a5ef0543b5579cf87a5cba52f37bbe82c161bc16..f56fb8942a46e8021913523f49dda04ab213aafb 100644

--- a/src/api.cc

+++ b/src/api.cc

@@ -5104,8 +5104,14 @@ class VisitorAdapter : public i::ObjectVisitor {

UNREACHABLE();

}

virtual void VisitEmbedderReference(i::Object** p, uint16_t class_id) {

+#ifdef V8_USE_OLD_STYLE_PERSISTENT_HANDLE_VISITORS

visitor_->VisitPersistentHandle(ToApi<Value>(i::Handle<i::Object>(p)),

class_id);

+#else

+ Persistent<Value> handle = ToApi<Value>(i::Handle<i::Object>(p));

dcarney 2013/05/28 12:58:11 can you make this a Value* and do some casting mag

marja 2013/05/28 14:07:18 Done.

+ visitor_->VisitPersistentHandle(&handle, class_id);

+ handle.ClearAndLeak();

+#endif

}

private:

PersistentHandleVisitor* visitor_;

« no previous file with comments | « include/v8.h ('k') | test/cctest/test-api.cc » ('j') | no next file with comments »