drive: Rewrite UpdateOpreation to access cache/metadata on the blocking pool

chrome/browser/chromeos/drive/file_cache.h

Index: chrome/browser/chromeos/drive/file_cache.h
diff --git a/chrome/browser/chromeos/drive/file_cache.h b/chrome/browser/chromeos/drive/file_cache.h
index bef7635c9ef455c2c266caaa94b7947b93fa4bcd..feb30c400662e1d2fe202c00fb22db539fa27e44 100644
--- a/chrome/browser/chromeos/drive/file_cache.h
+++ b/chrome/browser/chromeos/drive/file_cache.h
@@ -262,19 +262,17 @@ class FileCache {
                              const std::string& md5,
                              const FileOperationCallback& callback);
 
-  // Modifies cache state, which involves the following:
-  // - moves |source_path| to |dest_path| in persistent dir if
-  //   file is pinned or tmp dir otherwise, where |source_path| has .local
-  //   extension and |dest_path| has .<md5> extension
-  // - deletes symlink in outgoing dir
-  // - if file is pinned, updates symlink in pinned dir to reference
-  //   |dest_path|
+  // Runs ClearDirty() with |blocking_task_runner_| and runs |callback| with the
+  // result.
   // |callback| must not be null.
-  // Must be called on the UI thread.
   void ClearDirtyOnUIThread(const std::string& resource_id,
                             const std::string& md5,
                             const FileOperationCallback& callback);

[kinaba, 2013/05/28 06:29:40]

Looks like UpdateOperation is the only client using the method
(except the file_cache_unittest). Can we just drop this method?

[hashimoto, 2013/05/28 06:55:09]

Done.

 
+  // Clears dirty state of the specified entry.
+  FileError ClearDirty(const std::string& resource_id,
+                       const std::string& md5);
+
   // Runs Remove() on |blocking_task_runner_| and runs |callback| with the
   // result.
   // Must be called on the UI thread.
@@ -381,10 +379,6 @@ class FileCache {
   FileError MarkDirty(const std::string& resource_id,
                       const std::string& md5);
 
-  // Used to implement ClearDirtyOnUIThread.
-  FileError ClearDirty(const std::string& resource_id,
-                       const std::string& md5);
-
   // Used to implement ClearAllOnUIThread.
   bool ClearAll();