Service Worker: (Re-commit) Add FetchEvent.clientId

Service Worker: (Re-commit) Add FetchEvent.clientId

* The original CL was committed but reverted due to a use-of-uninitialized-value
report: https://codereview.chromium.org/1435633002/#msg31 This CL re-commits the
original CL with a patch that initializes the member, |is_main_resource_load|,
in its containing object's constructors.

Changes from the original commit:
 - Add the member init in the initializer list of the constructors of
   ServiceWorkerFetchRequest class (in service_worker_types.cc).

--
As per the latest spec update, this CL implements FetchEvent.clientId attribute.

Spec discussion: https://github.com/slightlyoff/ServiceWorker/issues/723#issuecomment-151326898
Spec: https://slightlyoff.github.io/ServiceWorker/spec/service_worker/#fetch-event-clientid

Intent to implement and ship: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/XlBHOIOCjUk

The layout tests for this CL are mostly taken from Mozilla's work instead of
making new ones to ensure compatibility: https://bugzilla.mozilla.org/show_bug.cgi?id=1222464

BUG=552309
Committed: https://crrev.com/f527e8602d8b4cb18c973d143cb6e33cb4ea6922
Cr-Commit-Position: refs/heads/master@{#370073}

[jungkees, 2016-01-18 04:20:05]

The CQ bit was checked by jungkee.song@samsung.com to run a CQ dry run

[commit-bot: I haz the power, 2016-01-18 04:20:13]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1597383002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1597383002/1

[commit-bot: I haz the power, 2016-01-18 04:20:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-01-18 04:20:17]

Dry run: No L-G-T-M from a valid reviewer yet. Only full committers are
accepted.
Even if an L-G-T-M may have been provided, it was from a non-committer,
_not_ a full super star committer.
See http://www.chromium.org/getting-involved/become-a-committer
Note that this has nothing to do with OWNERS files.

[jungkees, 2016-01-18 04:32:24]

Description was changed from

==========
Service Worker: (Re-commit) Add FetchEvent.clientId

* The original CL was committed but reverted due to a use-of-uninitialized-value
report: https://codereview.chromium.org/1267703003/#msg29 This CL re-commits the
original CL with a patch that initializes the member, |is_main_resource_load|,
in its containing objects constructors.

--
As per the latest spec update, this CL implements FetchEvent.clientId attribute.

Spec discussion:
https://github.com/slightlyoff/ServiceWorker/issues/723#issuecomment-151326898
Spec:
https://slightlyoff.github.io/ServiceWorker/spec/service_worker/#fetch-event-...

Intent to implement and ship:
https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/XlBHOIOCjUk

The layout tests for this CL are mostly taken from Mozilla's work instead of
making new ones to ensure compatibility:
https://bugzilla.mozilla.org/show_bug.cgi?id=1222464

BUG=552309
==========

to

==========
Service Worker: (Re-commit) Add FetchEvent.clientId

* The original CL was committed but reverted due to a use-of-uninitialized-value
report: https://codereview.chromium.org/1435633002/#msg31 This CL re-commits the
original CL with a patch that initializes the member, |is_main_resource_load|,
in its containing objects constructors.

--
As per the latest spec update, this CL implements FetchEvent.clientId attribute.

Spec discussion:
https://github.com/slightlyoff/ServiceWorker/issues/723#issuecomment-151326898
Spec:
https://slightlyoff.github.io/ServiceWorker/spec/service_worker/#fetch-event-...

Intent to implement and ship:
https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/XlBHOIOCjUk

The layout tests for this CL are mostly taken from Mozilla's work instead of
making new ones to ensure compatibility:
https://bugzilla.mozilla.org/show_bug.cgi?id=1222464

BUG=552309
==========

[jungkees, 2016-01-18 04:33:37]

Description was changed from

==========
Service Worker: (Re-commit) Add FetchEvent.clientId

* The original CL was committed but reverted due to a use-of-uninitialized-value
report: https://codereview.chromium.org/1435633002/#msg31 This CL re-commits the
original CL with a patch that initializes the member, |is_main_resource_load|,
in its containing objects constructors.

--
As per the latest spec update, this CL implements FetchEvent.clientId attribute.

Spec discussion:
https://github.com/slightlyoff/ServiceWorker/issues/723#issuecomment-151326898
Spec:
https://slightlyoff.github.io/ServiceWorker/spec/service_worker/#fetch-event-...

Intent to implement and ship:
https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/XlBHOIOCjUk

The layout tests for this CL are mostly taken from Mozilla's work instead of
making new ones to ensure compatibility:
https://bugzilla.mozilla.org/show_bug.cgi?id=1222464

BUG=552309
==========

to

==========
Service Worker: (Re-commit) Add FetchEvent.clientId

* The original CL was committed but reverted due to a use-of-uninitialized-value
report: https://codereview.chromium.org/1435633002/#msg31 This CL re-commits the
original CL with a patch that initializes the member, |is_main_resource_load|,
in its containing object's constructors.

--
As per the latest spec update, this CL implements FetchEvent.clientId attribute.

Spec discussion:
https://github.com/slightlyoff/ServiceWorker/issues/723#issuecomment-151326898
Spec:
https://slightlyoff.github.io/ServiceWorker/spec/service_worker/#fetch-event-...

Intent to implement and ship:
https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/XlBHOIOCjUk

The layout tests for this CL are mostly taken from Mozilla's work instead of
making new ones to ensure compatibility:
https://bugzilla.mozilla.org/show_bug.cgi?id=1222464

BUG=552309
==========

[jungkees, 2016-01-18 04:42:54]

Description was changed from

==========
Service Worker: (Re-commit) Add FetchEvent.clientId

* The original CL was committed but reverted due to a use-of-uninitialized-value
report: https://codereview.chromium.org/1435633002/#msg31 This CL re-commits the
original CL with a patch that initializes the member, |is_main_resource_load|,
in its containing object's constructors.

--
As per the latest spec update, this CL implements FetchEvent.clientId attribute.

Spec discussion:
https://github.com/slightlyoff/ServiceWorker/issues/723#issuecomment-151326898
Spec:
https://slightlyoff.github.io/ServiceWorker/spec/service_worker/#fetch-event-...

Intent to implement and ship:
https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/XlBHOIOCjUk

The layout tests for this CL are mostly taken from Mozilla's work instead of
making new ones to ensure compatibility:
https://bugzilla.mozilla.org/show_bug.cgi?id=1222464

BUG=552309
==========

to

==========
Service Worker: (Re-commit) Add FetchEvent.clientId

* The original CL was committed but reverted due to a use-of-uninitialized-value
report: https://codereview.chromium.org/1435633002/#msg31 This CL re-commits the
original CL with a patch that initializes the member, |is_main_resource_load|,
in its containing object's constructors.

Changes from the original commit:
 - Add the member init in the initializer list of the constructors of
   ServiceWorkerFetchRequest class (in service_worker_types.cc).

--
As per the latest spec update, this CL implements FetchEvent.clientId attribute.

Spec discussion:
https://github.com/slightlyoff/ServiceWorker/issues/723#issuecomment-151326898
Spec:
https://slightlyoff.github.io/ServiceWorker/spec/service_worker/#fetch-event-...

Intent to implement and ship:
https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/XlBHOIOCjUk

The layout tests for this CL are mostly taken from Mozilla's work instead of
making new ones to ensure compatibility:
https://bugzilla.mozilla.org/show_bug.cgi?id=1222464

BUG=552309
==========

[jungkees, 2016-01-18 10:04:32]

jungkee.song@samsung.com changed reviewers:
+ dcheng@chromium.org, falken@chromium.org, tkent@chromium.org

[jungkees, 2016-01-18 10:04:33]

This CL attempts to re-commit https://codereview.chromium.org/1435633002/ by
fixing the use-of-uninitialized-value warning (reported in
https://codereview.chromium.org/1435633002/#msg31). PTAL

https://codereview.chromium.org/1597383002/diff/20001/content/common/service_...
File content/common/service_worker/service_worker_types.cc (right):

https://codereview.chromium.org/1597383002/diff/20001/content/common/service_...
content/common/service_worker/service_worker_types.cc:24:
is_main_resource_load(false),
This line fixes the use-of-uninitialized-value warning reported in
https://codereview.chromium.org/1435633002/#msg31

https://codereview.chromium.org/1597383002/diff/20001/content/common/service_...
content/common/service_worker/service_worker_types.cc:39:
is_main_resource_load(false),
This line fixes the use-of-uninitialized-value warning reported in
https://codereview.chromium.org/1435633002/#msg31

[jungkees, 2016-01-18 10:05:01]

jungkee.song@samsung.com changed reviewers:
+ jinho.bang@samsung.com

[falken, 2016-01-18 11:25:13]

lgtm

BTW for relands, a convenient thing to do is upload the original change as the
first patchset, and then upload the patch with changes. Then reviewers can check
the delta to see the changes.

[jungkees, 2016-01-18 11:42:38]

Gotcha! I'll do so next time. If you expect me to do so with this change, let me
know. Thanks for the review!

[jungkees, 2016-01-18 12:01:58]

tkent@, dcheng@, PTAL. The only changed file is service_worker_types.cc where I
added an initialization of |is_main_resource_load| in the constructors.

[tkent, 2016-01-18 23:14:45]

lgtm

[dcheng, 2016-01-19 00:21:19]

lgtm

[jungkees, 2016-01-19 00:35:25]

The CQ bit was checked by jungkee.song@samsung.com

[commit-bot: I haz the power, 2016-01-19 00:35:38]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1597383002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1597383002/20001

[commit-bot: I haz the power, 2016-01-19 02:51:33]

Description was changed from

==========
Service Worker: (Re-commit) Add FetchEvent.clientId

* The original CL was committed but reverted due to a use-of-uninitialized-value
report: https://codereview.chromium.org/1435633002/#msg31 This CL re-commits the
original CL with a patch that initializes the member, |is_main_resource_load|,
in its containing object's constructors.

Changes from the original commit:
 - Add the member init in the initializer list of the constructors of
   ServiceWorkerFetchRequest class (in service_worker_types.cc).

--
As per the latest spec update, this CL implements FetchEvent.clientId attribute.

Spec discussion:
https://github.com/slightlyoff/ServiceWorker/issues/723#issuecomment-151326898
Spec:
https://slightlyoff.github.io/ServiceWorker/spec/service_worker/#fetch-event-...

Intent to implement and ship:
https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/XlBHOIOCjUk

The layout tests for this CL are mostly taken from Mozilla's work instead of
making new ones to ensure compatibility:
https://bugzilla.mozilla.org/show_bug.cgi?id=1222464

BUG=552309
==========

to

==========
Service Worker: (Re-commit) Add FetchEvent.clientId

* The original CL was committed but reverted due to a use-of-uninitialized-value
report: https://codereview.chromium.org/1435633002/#msg31 This CL re-commits the
original CL with a patch that initializes the member, |is_main_resource_load|,
in its containing object's constructors.

Changes from the original commit:
 - Add the member init in the initializer list of the constructors of
   ServiceWorkerFetchRequest class (in service_worker_types.cc).

--
As per the latest spec update, this CL implements FetchEvent.clientId attribute.

Spec discussion:
https://github.com/slightlyoff/ServiceWorker/issues/723#issuecomment-151326898
Spec:
https://slightlyoff.github.io/ServiceWorker/spec/service_worker/#fetch-event-...

Intent to implement and ship:
https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/XlBHOIOCjUk

The layout tests for this CL are mostly taken from Mozilla's work instead of
making new ones to ensure compatibility:
https://bugzilla.mozilla.org/show_bug.cgi?id=1222464

BUG=552309
==========

[commit-bot: I haz the power, 2016-01-19 02:51:37]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-01-19 02:53:46]

Description was changed from

==========
Service Worker: (Re-commit) Add FetchEvent.clientId

* The original CL was committed but reverted due to a use-of-uninitialized-value
report: https://codereview.chromium.org/1435633002/#msg31 This CL re-commits the
original CL with a patch that initializes the member, |is_main_resource_load|,
in its containing object's constructors.

Changes from the original commit:
 - Add the member init in the initializer list of the constructors of
   ServiceWorkerFetchRequest class (in service_worker_types.cc).

--
As per the latest spec update, this CL implements FetchEvent.clientId attribute.

Spec discussion:
https://github.com/slightlyoff/ServiceWorker/issues/723#issuecomment-151326898
Spec:
https://slightlyoff.github.io/ServiceWorker/spec/service_worker/#fetch-event-...

Intent to implement and ship:
https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/XlBHOIOCjUk

The layout tests for this CL are mostly taken from Mozilla's work instead of
making new ones to ensure compatibility:
https://bugzilla.mozilla.org/show_bug.cgi?id=1222464

BUG=552309
==========

to

==========
Service Worker: (Re-commit) Add FetchEvent.clientId

* The original CL was committed but reverted due to a use-of-uninitialized-value
report: https://codereview.chromium.org/1435633002/#msg31 This CL re-commits the
original CL with a patch that initializes the member, |is_main_resource_load|,
in its containing object's constructors.

Changes from the original commit:
 - Add the member init in the initializer list of the constructors of
   ServiceWorkerFetchRequest class (in service_worker_types.cc).

--
As per the latest spec update, this CL implements FetchEvent.clientId attribute.

Spec discussion:
https://github.com/slightlyoff/ServiceWorker/issues/723#issuecomment-151326898
Spec:
https://slightlyoff.github.io/ServiceWorker/spec/service_worker/#fetch-event-...

Intent to implement and ship:
https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/XlBHOIOCjUk

The layout tests for this CL are mostly taken from Mozilla's work instead of
making new ones to ensure compatibility:
https://bugzilla.mozilla.org/show_bug.cgi?id=1222464

BUG=552309

Committed: https://crrev.com/f527e8602d8b4cb18c973d143cb6e33cb4ea6922
Cr-Commit-Position: refs/heads/master@{#370073}
==========

[commit-bot: I haz the power, 2016-01-19 02:53:47]

Patchset 2 (id:??) landed as
https://crrev.com/f527e8602d8b4cb18c973d143cb6e33cb4ea6922
Cr-Commit-Position: refs/heads/master@{#370073}