Issue 159733003: Don't run paused animations on the compositor.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 159733003: Don't run paused animations on the compositor. (Closed)

Created:
6 years, 10 months ago by andersr

Modified:
6 years, 10 months ago

Reviewers:
dstockwell

CC:
blink-reviews, shans, rjwright, alancutter (OOO until 2018), Mike Lawther (Google), dstockwell, Timothy Loh, darktears, Steve Block, dino_apple.com, Eric Willigers

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Visibility:
Public.

More Reviews

Description

Don't run paused animations on the compositor. There is a bug where compositable animations are started (and played back) even if their initial state is "paused". It would appear that pausing/unpausing composited animations is not implemented, and that pausing a currently running composited animation causes it to be permanently "thrown out" of the compositor. In light of this, I suggest to simply not start paused animations on the compositor, for now. BUG=342192 TEST=manual Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=167140

Patch Set 1 #

Patch Set 2 : Add automated test. #

Created: 6 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+60 lines, -1 line)			Patch
A	LayoutTests/animations/animation-paused-hardware.html	View	1	1 chunk	+38 lines, -0 lines	0 comments	Download
A	LayoutTests/animations/animation-paused-hardware-expected.html	View	1	1 chunk	+21 lines, -0 lines	0 comments	Download
M	Source/core/animation/Player.cpp	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

dstockwell

The fix looks good, but we need a test. This should be reproducible under the ...

6 years, 10 months ago (2014-02-12 00:22:57 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/andersr@opera.com/159733003/50001

6 years, 10 months ago (2014-02-14 00:10:03 UTC) #5

Message was sent while issue was closed.

Change committed as 167140

Expand Messages | Collapse Messages