Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(274)

Unified Diff: runtime/vm/intermediate_language.h

Issue 15973010: Split LoadStatic into two instructions: load static filed, load value. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/vm/intermediate_language.h
===================================================================
--- runtime/vm/intermediate_language.h (revision 24013)
+++ runtime/vm/intermediate_language.h (working copy)
@@ -3380,28 +3380,32 @@
};
-class LoadStaticFieldInstr : public TemplateDefinition<0> {
+class LoadStaticFieldInstr : public TemplateDefinition<1> {
public:
- explicit LoadStaticFieldInstr(const Field& field) : field_(field) {}
+ explicit LoadStaticFieldInstr(Value* field_value) {
+ ASSERT(field_value->BindsToConstant());
+ SetInputAt(0, field_value);
+ }
DECLARE_INSTRUCTION(LoadStaticField)
virtual CompileType ComputeType() const;
- const Field& field() const { return field_; }
+ const Field& StaticField() const;
+ Value* field_value() const { return inputs_[0]; }
+
virtual void PrintOperandsTo(BufferFormatter* f) const;
virtual bool CanDeoptimize() const { return false; }
- virtual bool AllowsCSE() const { return field_.is_final(); }
+ virtual bool AllowsCSE() const { return StaticField().is_final(); }
virtual EffectSet Effects() const { return EffectSet::None(); }
virtual EffectSet Dependencies() const;
virtual bool AttributesEqual(Instruction* other) const;
virtual bool MayThrow() const { return false; }
+
private:
- const Field& field_;
-
DISALLOW_COPY_AND_ASSIGN(LoadStaticFieldInstr);
};

Powered by Google App Engine
This is Rietveld 408576698