Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(125)

Issue 15973007: Don't use __timezone when using uClibc (Closed)

Created:
7 years, 6 months ago by Mostyn Bramley-Moore
Modified:
7 years, 6 months ago
Reviewers:
jungshik at Google
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/deps/icu46.git@master
Visibility:
Public.

Description

Don't use __timezone when using uClibc It appears that plinux.h is a generated file, created by autoconf on a glibc system, so it naturally outputs a config for glibc. This patch changes one of the settings so that it doesn't break when used with uClibc. Patch by Mostyn Bramley-Moore BUG=NONE TEST=Opera builds work fine.

Patch Set 1 #

Patch Set 2 : update README.chromium #

Patch Set 3 : Don't use __timezone when using uClibc #

Patch Set 4 : fix typo #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M README.chromium View 1 3 1 chunk +2 lines, -0 lines 0 comments Download
M public/common/unicode/plinux.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (0 generated)
Mostyn Bramley-Moore
This small patch makes the plinux.h platform configuration file also work on uClibc systems (it ...
7 years, 6 months ago (2013-06-11 21:32:46 UTC) #1
jungshik at Google
On 2013/06/11 21:32:46, Mostyn Bramley-Moore wrote: > This small patch makes the plinux.h platform configuration ...
7 years, 6 months ago (2013-06-11 22:02:51 UTC) #2
Mostyn Bramley-Moore
> Can you update README.chromium (item 2) to refer to this CL? Adding something > ...
7 years, 6 months ago (2013-06-11 22:07:59 UTC) #3
jungshik at Google
LGTM
7 years, 6 months ago (2013-06-11 22:09:00 UTC) #4
Mostyn Bramley-Moore
Thanks. Since CQ doesn't appear to be hooked up- can you please land this for ...
7 years, 6 months ago (2013-06-11 22:27:02 UTC) #5
jungshik at Google
On 2013/06/11 22:27:02, Mostyn Bramley-Moore wrote: > Thanks. > > Since CQ doesn't appear to ...
7 years, 6 months ago (2013-06-11 22:29:11 UTC) #6
jungshik at Google
Don't use __timezone when using uClibc It appears that plinux.h is a generated file, created ...
7 years, 6 months ago (2013-06-11 23:13:54 UTC) #7
Mostyn Bramley-Moore
Closing this issue now that this has landed: https://chromium.googlesource.com/chromium/third_party/icu46/+/03f72c5b2621bc684a471baffb154828615293fe
7 years, 6 months ago (2013-06-12 09:13:19 UTC) #8
Mostyn Bramley-Moore
Oops, a typo slipped in! Fixed in patchset 4.
7 years, 6 months ago (2013-06-12 20:16:50 UTC) #9
Mostyn Bramley-Moore
7 years, 6 months ago (2013-06-13 07:34:42 UTC) #10
Fixed here, I see (thanks):
https://codereview.chromium.org/16862003/

Powered by Google App Engine
This is Rietveld 408576698