Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2946)

Unified Diff: base/base.gyp

Issue 1597273005: Move ChromiumMultiDex to BuildConfig. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase. Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « base/android/java/templates/ChromiumMultiDex.template ('k') | build/config/android/rules.gni » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/base.gyp
diff --git a/base/base.gyp b/base/base.gyp
index 328e31f4de8dfe5ba1872b12103a6c487aea3acb..38cb81197dd7eaa93ef0f1e1d0e5ec98df4e6e5c 100644
--- a/base/base.gyp
+++ b/base/base.gyp
@@ -1415,14 +1415,14 @@
'includes': [ '../build/android/java_cpp_template.gypi' ],
},
{
- # GN: //base:base_multidex_gen
- 'target_name': 'base_multidex_gen',
+ # GN: //base:base_build_config_gen
+ 'target_name': 'base_build_config_gen',
'type': 'none',
'sources': [
- 'android/java/templates/ChromiumMultiDex.template',
+ 'android/java/templates/BuildConfig.template',
],
'variables': {
- 'package_name': 'org/chromium/base/multidex',
+ 'package_name': 'org/chromium/base',
'template_deps': [],
},
'includes': ['../build/android/java_cpp_template.gypi'],
@@ -1443,7 +1443,7 @@
'variables': {
'java_in_dir': 'android/java',
'jar_excluded_classes': [
- '*/ChromiumMultiDex.class',
+ '*/BuildConfig.class',
'*/NativeLibraries.class',
],
},
@@ -1452,14 +1452,14 @@
'base_java_library_load_from_apk_status_codes',
'base_java_library_process_type',
'base_java_memory_pressure_level',
- 'base_multidex_gen',
+ 'base_build_config_gen',
'base_native_libraries_gen',
'../third_party/android_tools/android_tools.gyp:android_support_multidex_javalib',
'../third_party/jsr-305/jsr-305.gyp:jsr_305_javalib',
],
'all_dependent_settings': {
'variables': {
- 'generate_multidex_config': 1,
+ 'generate_build_config': 1,
},
},
'includes': [ '../build/java.gypi' ],
@@ -1523,7 +1523,7 @@
'target_name': 'base_junit_test_support',
'type': 'none',
'dependencies': [
- 'base_multidex_gen',
+ 'base_build_config_gen',
'../testing/android/junit/junit_test.gyp:junit_test_support',
'../third_party/android_tools/android_tools.gyp:android_support_multidex_javalib',
],
« no previous file with comments | « base/android/java/templates/ChromiumMultiDex.template ('k') | build/config/android/rules.gni » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698