chrome/browser/ui/cocoa/extensions/extension_installed_bubble_controller.mm - Issue 159723009: Exclude extension settings strings for platforms that don't have extensions.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/extensions/extension_installed_bubble_controller.mm

Issue 159723009: Exclude extension settings strings for platforms that don't have extensions. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: newt's nit Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/ui/cocoa/extensions/extension_installed_bubble_controller.mm

diff --git a/chrome/browser/ui/cocoa/extensions/extension_installed_bubble_controller.mm b/chrome/browser/ui/cocoa/extensions/extension_installed_bubble_controller.mm

index 061fc6f86e5f57872d03c57d5056369287829fb4..360a959eaac254f3b0e77e6678f9e181f53e247a 100644

--- a/chrome/browser/ui/cocoa/extensions/extension_installed_bubble_controller.mm

+++ b/chrome/browser/ui/cocoa/extensions/extension_installed_bubble_controller.mm

@@ -440,9 +440,8 @@ class ExtensionLoadedNotificationObserver

// First calculate the height of the sign-in promo.

NSFont* font = [NSFont systemFontOfSize:[NSFont smallSystemFontSize]];

- NSString* link(l10n_util::GetNSStringFWithFixup(

- IDS_EXTENSION_INSTALLED_SIGNIN_PROMO_LINK,

- l10n_util::GetStringUTF16(IDS_SHORT_PRODUCT_NAME)));

+ NSString* link(l10n_util::GetNSStringWithFixup(

+ IDS_EXTENSION_INSTALLED_SIGNIN_PROMO_LINK));

NSString* message(l10n_util::GetNSStringWithFixup(

IDS_EXTENSION_INSTALLED_SIGNIN_PROMO));

« no previous file with comments | « chrome/app/google_chrome_strings.grd ('k') | chrome/browser/ui/views/extensions/extension_installed_bubble_view.cc » ('j') | no next file with comments »