Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(601)

Unified Diff: base/logging.cc

Issue 159723: Do not abort the process if thread owning the log mutex has crashed. (Closed)
Patch Set: Created 11 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/logging.cc
diff --git a/base/logging.cc b/base/logging.cc
index b5af671eb4f465940846f4be8156005bc2a70a93..27f2724f0f59999a3112b07e7fb362778f9a9b2e 100644
--- a/base/logging.cc
+++ b/base/logging.cc
@@ -485,7 +485,12 @@ LogMessage::~LogMessage() {
#if defined(OS_WIN)
DWORD r = ::WaitForSingleObject(log_mutex, INFINITE);
- DCHECK(r != WAIT_ABANDONED);
+ if (r == WAIT_ABANDONED) {
+ // Do not abort the process here. UI tests might be crashy sometimes,
+ // and aborting the test binary only makes the problem worse.
+ // For more info see http://crbug.com/18028.
+ LOG(ERROR) << "Thread owning the log mutex has crashed.";
cpu_(ooo_6.6-7.5) 2009/07/31 23:04:05 hmmm ... you are calling LOG()which ends up back h
+ }
#elif defined(OS_POSIX)
pthread_mutex_lock(&log_mutex);
#endif
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698