Do not abort the process if thread owning the log mutex has crashed.

Do not abort the process if thread owning the log mutex has crashed.

It makes UI tests even more flaky. However, we still log that event.

TEST=none
http://crbug.com/18028

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=22195

[brettw, 2009-07-31 20:02:29]

LGTM

[cpu_(ooo_6.6-7.5), 2009-07-31 23:04:05]

http://codereview.chromium.org/159723/diff/1/2
File base/logging.cc (right):

http://codereview.chromium.org/159723/diff/1/2#newcode492
Line 492: LOG(ERROR) << "Thread owning the log mutex has crashed.";
hmmm ... you are calling LOG()which ends up back here?

I don't see anybody calling back into log here, I think for a a good reason.
Probably that DCHECK was also wrong.

[Paweł Hajdan Jr., 2009-07-31 23:07:23]

On Fri, Jul 31, 2009 at 16:04, <cpu@chromium.org> wrote:

> http://codereview.chromium.org/159723/diff/1/2
> File base/logging.cc (right):
>
> http://codereview.chromium.org/159723/diff/1/2#newcode492
> Line 492: LOG(ERROR) << "Thread owning the log mutex has crashed.";
> hmmm ... you are calling LOG()which ends up back here?
>
> I don't see anybody calling back into log here, I think for a a good
> reason. Probably that DCHECK was also wrong.


Do you think it would be better to just remove the LOG(ERROR) statement?

[cpu_(ooo_6.6-7.5), 2009-07-31 23:15:57]

Yes at this point you can only call things _below_ the log library, so things
like DebugOutputStringA() or __debugbreak() or some crossplatform versions of
that.


On 2009/07/31 23:07:23, Paweł Hajdan Jr. wrote:
> On Fri, Jul 31, 2009 at 16:04, <cpu@chromium.org> wrote:
> 
> > http://codereview.chromium.org/159723/diff/1/2
> > File base/logging.cc (right):
> >
> > http://codereview.chromium.org/159723/diff/1/2#newcode492
> > Line 492: LOG(ERROR) << "Thread owning the log mutex has crashed.";
> > hmmm ... you are calling LOG()which ends up back here?
> >
> > I don't see anybody calling back into log here, I think for a a good
> > reason. Probably that DCHECK was also wrong.
> 
> 
> Do you think it would be better to just remove the LOG(ERROR) statement?
>

[brettw, 2009-08-01 00:26:42]

I'm not actually sure what this is telling us, so I wouldn't worry too
much about the logging statement. I think it should be OK to just
remove it.

Brett

On Fri, Jul 31, 2009 at 11:15 PM, <cpu@chromium.org> wrote:
> Yes at this point you can only call things _below_ the log library, so
> things like DebugOutputStringA() or __debugbreak() or some crossplatform
> versions of that.
>
>
> On 2009/07/31 23:07:23, Pawe=C5=82 Hajdan Jr. wrote:
>>
>> On Fri, Jul 31, 2009 at 16:04, <cpu@chromium.org> wrote:
>
>> > http://codereview.chromium.org/159723/diff/1/2
>> > File base/logging.cc (right):
>> >
>> > http://codereview.chromium.org/159723/diff/1/2#newcode492
>> > Line 492: LOG(ERROR) << "Thread owning the log mutex has crashed.";
>> > hmmm ... you are calling LOG()which ends up back here?
>> >
>> > I don't see anybody calling back into log here, I think for a a good
>> > reason. Probably that DCHECK was also wrong.
>
>
>> Do you think it would be better to just remove the LOG(ERROR)
>
> statement?
>
>
>
>
> http://codereview.chromium.org/159723
>