Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(195)

Issue 15972006: TransformOperations should be able to blend outside the range [0, 1] (Closed)

Created:
7 years, 6 months ago by Ian Vollick
Modified:
7 years, 6 months ago
Reviewers:
danakj, ajuma
CC:
chromium-reviews, cc-bugs_chromium.org
Visibility:
Public.

Description

After http://crrev.com/202755, timing functions can now produce values outside the range [0, 1]. Unfortunately, these values are getting clamped when they are used for blending. This CL removes that extra clamping and adds unit tests for this extrapolation. BUG=178299 R=ajuma@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=203808

Patch Set 1 #

Patch Set 2 : Added tests. #

Total comments: 1

Patch Set 3 : Add gfx::Transform unittests #

Patch Set 4 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+128 lines, -31 lines) Patch
M cc/animation/transform_operation.cc View 1 chunk +0 lines, -6 lines 0 comments Download
M cc/animation/transform_operations.cc View 1 chunk +0 lines, -10 lines 0 comments Download
M cc/animation/transform_operations_unittest.cc View 1 5 chunks +106 lines, -0 lines 0 comments Download
M ui/gfx/transform.cc View 1 chunk +0 lines, -8 lines 0 comments Download
M ui/gfx/transform_unittest.cc View 1 2 7 chunks +22 lines, -7 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
Ian Vollick
7 years, 6 months ago (2013-06-01 03:48:39 UTC) #1
ajuma
lgtm with nit: https://codereview.chromium.org/15972006/diff/2001/ui/gfx/transform.cc File ui/gfx/transform.cc (left): https://codereview.chromium.org/15972006/diff/2001/ui/gfx/transform.cc#oldcode375 ui/gfx/transform.cc:375: Please add a gfx::Transform unit test ...
7 years, 6 months ago (2013-06-01 14:54:12 UTC) #2
Ian Vollick
On 2013/06/01 14:54:12, ajuma wrote: > lgtm with nit: > > https://codereview.chromium.org/15972006/diff/2001/ui/gfx/transform.cc > File ui/gfx/transform.cc ...
7 years, 6 months ago (2013-06-03 01:28:52 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vollick@chromium.org/15972006/10001
7 years, 6 months ago (2013-06-03 01:29:05 UTC) #4
commit-bot: I haz the power
Retried try job too often on chromium_presubmit for step(s) presubmit http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_presubmit&number=6331
7 years, 6 months ago (2013-06-03 01:39:06 UTC) #5
Ian Vollick
+danakj for OWNERS
7 years, 6 months ago (2013-06-03 01:43:15 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vollick@chromium.org/15972006/10001
7 years, 6 months ago (2013-06-03 19:04:18 UTC) #7
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) base_unittests, cacheinvalidation_unittests, cc_unittests, check_deps, chrome_frame_net_tests, chrome_frame_tests, ...
7 years, 6 months ago (2013-06-04 01:09:29 UTC) #8
Ian Vollick
7 years, 6 months ago (2013-06-04 01:30:02 UTC) #9
Message was sent while issue was closed.
Committed patchset #4 manually as r203808 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698