Add MoveOperationTest for drive::file_system::MoveOperationTest.

Add MoveOperationTest for drive::file_system::MoveOperationTest.

The test contents are not changed actually.
This is for splitting the Move() releated tests from FileSystemTest
to its actual implementation class.

BUG=223854
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=202058

[hidehiko, 2013-05-24 04:45:14]

lgtm with nits.

https://codereview.chromium.org/15972002/diff/4001/chrome/browser/chromeos/dr...
File chrome/browser/chromeos/drive/file_system/move_operation_unittest.cc
(right):

https://codereview.chromium.org/15972002/diff/4001/chrome/browser/chromeos/dr...
chrome/browser/chromeos/drive/file_system/move_operation_unittest.cc:37: 
How about check
ASSERT_EQ(FILE_ERROR_NOT_FOUND, GetLocalResourceEntry(dest_path, &dest_entry));
here? Ditto for below?

https://codereview.chromium.org/15972002/diff/4001/chrome/browser/chromeos/dr...
File chrome/browser/chromeos/drive/file_system/operation_test_base.h (right):

https://codereview.chromium.org/15972002/diff/4001/chrome/browser/chromeos/dr...
chrome/browser/chromeos/drive/file_system/operation_test_base.h:61:
std::set<base::FilePath> changed_paths_;
QQ: Don't we need to keep the order?

[kinaba, 2013-05-24 05:05:42]

Thanks for the comments.

https://codereview.chromium.org/15972002/diff/4001/chrome/browser/chromeos/dr...
File chrome/browser/chromeos/drive/file_system/move_operation_unittest.cc
(right):

https://codereview.chromium.org/15972002/diff/4001/chrome/browser/chromeos/dr...
chrome/browser/chromeos/drive/file_system/move_operation_unittest.cc:37: 
On 2013/05/24 04:45:14, hidehiko wrote:
> How about check
> ASSERT_EQ(FILE_ERROR_NOT_FOUND, GetLocalResourceEntry(dest_path,
&dest_entry));
> here? Ditto for below?

Sounds good. Done.

https://codereview.chromium.org/15972002/diff/4001/chrome/browser/chromeos/dr...
File chrome/browser/chromeos/drive/file_system/operation_test_base.h (right):

https://codereview.chromium.org/15972002/diff/4001/chrome/browser/chromeos/dr...
chrome/browser/chromeos/drive/file_system/operation_test_base.h:61:
std::set<base::FilePath> changed_paths_;
On 2013/05/24 04:45:14, hidehiko wrote:
> QQ: Don't we need to keep the order?

I don't think so, at least so far.

Existing tests using EXPECT_CALL(mock, OnDirectoryChanged(...)).Times(1)
does not care about the order, and I believe it is the right thing;
we are not ensuring anything about, say, in which order Move() notifies changes.

If we came to the situation that we do need orders, let's re-think about it
then.

[hidehiko, 2013-05-24 05:13:49]

lgtm

[commit-bot: I haz the power, 2013-05-24 05:19:28]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/kinaba@chromium.org/15972002/12001

[commit-bot: I haz the power, 2013-05-24 06:34:16]

Retried try job too often on linux_chromeos for step(s) unit_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_chro...

[commit-bot: I haz the power, 2013-05-24 07:51:23]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/kinaba@chromium.org/15972002/26001

[commit-bot: I haz the power, 2013-05-24 11:27:05]

Change committed as 202058