Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(743)

Issue 1597163002: wasm: change the module memory size to be multiples of the page size, 64k. (Closed)

Created:
4 years, 11 months ago by dougc
Modified:
4 years, 9 months ago
Reviewers:
titzer
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

wasm: change the module memory size to be multiples of the page size, 64k. BUG= Committed: https://crrev.com/76f37d3ba6bcd9f03f9418ea2f5cbae0568ce47f Cr-Commit-Position: refs/heads/master@{#34450}

Patch Set 1 #

Patch Set 2 : Change a uint32_t memory size to be size_t. #

Patch Set 3 : Revert the uint32_t to size_t change. Broke 64bit builds. #

Patch Set 4 : Further test fixes. #

Patch Set 5 : Update for recently improved segment checks #

Patch Set 6 : Rebase #

Patch Set 7 : Rebase #

Patch Set 8 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+42 lines, -39 lines) Patch
M src/wasm/module-decoder.cc View 1 2 3 4 5 6 7 3 chunks +7 lines, -5 lines 0 comments Download
M src/wasm/wasm-module.h View 1 2 3 4 5 6 7 1 chunk +5 lines, -4 lines 0 comments Download
M src/wasm/wasm-module.cc View 1 2 3 4 5 6 7 5 chunks +8 lines, -8 lines 0 comments Download
M test/mjsunit/wasm/calls.js View 1 2 3 4 5 6 7 5 chunks +5 lines, -5 lines 0 comments Download
M test/mjsunit/wasm/ffi-error.js View 1 2 3 4 5 6 7 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/wasm/instantiate-module-basic.js View 1 2 3 4 5 6 7 2 chunks +2 lines, -2 lines 0 comments Download
M test/mjsunit/wasm/module-memory.js View 1 2 3 4 5 6 7 4 chunks +5 lines, -5 lines 0 comments Download
M test/mjsunit/wasm/params.js View 1 2 3 4 5 6 7 2 chunks +2 lines, -2 lines 0 comments Download
M test/unittests/wasm/module-decoder-unittest.cc View 1 2 3 4 5 6 7 3 chunks +7 lines, -7 lines 0 comments Download

Messages

Total messages: 15 (8 generated)
dougc
4 years, 11 months ago (2016-01-17 13:42:53 UTC) #3
titzer
On 2016/01/17 13:42:53, dougc wrote: lgtm, though let's coordinate with the changes to sexpr_wasm before ...
4 years, 11 months ago (2016-01-19 17:21:16 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1597163002/100001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1597163002/100001
4 years, 10 months ago (2016-02-04 00:26:52 UTC) #6
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 10 months ago (2016-02-04 00:51:22 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1597163002/140001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1597163002/140001
4 years, 9 months ago (2016-03-02 23:39:33 UTC) #11
commit-bot: I haz the power
Committed patchset #8 (id:140001)
4 years, 9 months ago (2016-03-02 23:59:03 UTC) #13
commit-bot: I haz the power
4 years, 9 months ago (2016-03-03 00:00:08 UTC) #15
Message was sent while issue was closed.
Patchset 8 (id:??) landed as
https://crrev.com/76f37d3ba6bcd9f03f9418ea2f5cbae0568ce47f
Cr-Commit-Position: refs/heads/master@{#34450}

Powered by Google App Engine
This is Rietveld 408576698