Issue 159715: Implement FindBarGtk::StopAnimation()....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 159715: Implement FindBarGtk::StopAnimation().... (Closed)

Created:
11 years, 4 months ago by Evan Stade

Modified:
9 years, 6 months ago

Reviewers:
tony, Finnur

CC:
chromium-reviews_googlegroups.com, Ben Goodger (Google)

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Implement FindBarGtk::StopAnimation(). Not convinced it's 100% necessary but it can't hurt. BUG=11979 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=22170

Patch Set 1 #

Created: 11 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+9 lines, -3 lines)			Patch
M	chrome/browser/gtk/find_bar_gtk.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/gtk/slide_animator_gtk.h	View	1 chunk	+3 lines, -0 lines	0 comments	Download
M	chrome/browser/gtk/slide_animator_gtk.cc	View	1 chunk	+4 lines, -0 lines	0 comments	Download
M	chrome/browser/views/find_bar_win.cc	View	1 chunk	+1 line, -2 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Evan Stade

11 years, 4 months ago (2009-07-31 19:40:30 UTC) #3

On Fri, Jul 31, 2009 at 12:38 PM, <tony@chromium.org> wrote:
> LGTM. =A0Is the windows change just for consistency?
>
> http://codereview.chromium.org/159715
>

yea, it doesn't functionally change anything (End() is a noop if the
animation isn't running)

Expand Messages | Collapse Messages