Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(102)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 15971005: Move the WebCursor sources from webkit/glue to webkit/common/cursors. (Closed)

Created:
7 years, 6 months ago by ananta
Modified:
7 years, 6 months ago
CC:
chromium-reviews, ctguil+watch_chromium.org, yusukes+watch_chromium.org, hashimoto+watch_chromium.org, aboxhall+watch_chromium.org, yoshiki+watch_chromium.org, jianli, Dmitry Titov, jam, penghuang+watch_chromium.org, sail+watch_chromium.org, davidbarr+watch_chromium.org, joi+watch-content_chromium.org, nona+watch_chromium.org, yuzo+watch_chromium.org, jennb, darin-cc_chromium.org, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org, dcheng, James Su, zork+watch_chromium.org
Visibility:
Public.

Description

Move the WebCursor sources from webkit/glue to webkit/common/cursors. This CL introduces a new target webkit_common which lives in webkit_common.gypi and builds a dll/static lib based on the component flag. This target only contains the webcursor sources for now. BUG=237249 TBR=jamesr@chromium.org, mnaganov@chromium.org, palmer@chromium.org, piman@chromium.org, sky@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=203280

Patch Set 1 #

Total comments: 6

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Patch Set 5 : #

Patch Set 6 : #

Patch Set 7 : #

Patch Set 8 : #

Patch Set 9 : #

Patch Set 10 : #

Patch Set 11 : #

Patch Set 12 : #

Patch Set 13 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+162 lines, -2229 lines) Patch
M android_webview/tools/third_party_files_whitelist.txt View 1 2 3 4 5 6 7 8 9 10 11 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/DEPS View 1 2 3 4 5 6 7 8 9 10 11 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/panels/panel_window_controller_cocoa.mm View 1 2 3 4 5 6 7 8 9 10 11 1 chunk +1 line, -1 line 0 comments Download
M chrome/chrome_browser_ui.gypi View 1 2 3 4 5 6 7 8 9 10 11 12 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_impl.cc View 1 2 3 4 5 6 7 8 9 10 11 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/render_widget_host_view_aura.h View 1 2 3 4 5 6 7 8 9 10 11 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/render_widget_host_view_gtk.h View 1 2 3 4 5 6 7 8 9 10 11 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/render_widget_host_view_guest.h View 1 2 3 4 5 6 7 8 9 10 11 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/render_widget_host_view_mac.h View 1 2 3 4 5 6 7 8 9 10 11 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/render_widget_host_view_win.h View 1 2 3 4 5 6 7 8 9 10 11 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/render_widget_host_view_win.cc View 1 2 3 4 5 6 7 8 9 10 11 1 chunk +1 line, -1 line 0 comments Download
M content/common/browser_plugin/browser_plugin_messages.h View 1 2 3 4 5 6 7 8 9 10 11 1 chunk +1 line, -1 line 0 comments Download
M content/common/content_param_traits.h View 1 2 3 4 5 6 7 8 9 10 11 1 chunk +1 line, -1 line 0 comments Download
M content/common_child/plugin_messages.h View 1 2 3 4 5 6 7 8 9 10 11 1 chunk +1 line, -1 line 0 comments Download
M content/content_browser.gypi View 1 2 3 4 5 6 7 8 9 10 11 1 chunk +1 line, -0 lines 0 comments Download
M content/content_renderer.gypi View 1 2 3 4 5 6 7 8 9 10 11 1 chunk +1 line, -0 lines 0 comments Download
M content/content_tests.gypi View 1 2 3 4 5 6 7 8 9 10 11 3 chunks +2 lines, -1 line 0 comments Download
M content/plugin/webplugin_delegate_stub.cc View 1 2 3 4 5 6 7 8 9 10 11 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/browser_plugin/browser_plugin_manager_impl.cc View 1 2 3 4 5 6 7 8 9 10 11 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/render_widget.h View 1 2 3 4 5 6 7 8 9 10 11 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/webplugin_delegate_proxy.cc View 1 2 3 4 5 6 7 8 9 10 11 1 chunk +1 line, -1 line 0 comments Download
A + webkit/common/cursors/webcursor.h View 3 chunks +5 lines, -5 lines 0 comments Download
A + webkit/common/cursors/webcursor.cc View 1 chunk +1 line, -1 line 0 comments Download
A + webkit/common/cursors/webcursor_android.cc View 1 chunk +1 line, -1 line 0 comments Download
A + webkit/common/cursors/webcursor_aura.cc View 1 chunk +1 line, -1 line 0 comments Download
A + webkit/common/cursors/webcursor_aurawin.cc View 1 chunk +1 line, -1 line 0 comments Download
A + webkit/common/cursors/webcursor_aurax11.cc View 1 chunk +1 line, -1 line 0 comments Download
A + webkit/common/cursors/webcursor_gtk.cc View 2 chunks +2 lines, -2 lines 0 comments Download
A + webkit/common/cursors/webcursor_gtk_data.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + webkit/common/cursors/webcursor_mac.mm View 3 chunks +1 line, -3 lines 0 comments Download
A + webkit/common/cursors/webcursor_null.cc View 1 chunk +1 line, -1 line 0 comments Download
A + webkit/common/cursors/webcursor_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
A + webkit/common/cursors/webcursor_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M webkit/common/webkit_common.gypi View 1 2 3 4 5 6 7 8 9 10 11 1 chunk +83 lines, -0 lines 0 comments Download
A webkit/common/webkit_common_export.h View 1 2 3 4 5 1 chunk +29 lines, -0 lines 0 comments Download
M webkit/glue/cursor_utils.h View 1 2 3 4 5 6 7 8 9 10 11 1 chunk +1 line, -1 line 0 comments Download
M webkit/glue/cursor_utils.cc View 1 2 3 4 5 6 7 8 9 10 11 1 chunk +0 lines, -1 line 0 comments Download
D webkit/glue/webcursor.h View 1 2 3 4 5 6 7 8 9 10 11 1 chunk +0 lines, -187 lines 0 comments Download
D webkit/glue/webcursor.cc View 1 2 3 4 5 6 7 8 9 10 11 1 chunk +0 lines, -261 lines 0 comments Download
D webkit/glue/webcursor_android.cc View 1 2 3 4 5 6 7 8 9 10 11 1 chunk +0 lines, -29 lines 0 comments Download
D webkit/glue/webcursor_aura.cc View 1 2 3 4 5 6 7 8 9 10 11 1 chunk +0 lines, -110 lines 0 comments Download
D webkit/glue/webcursor_aurawin.cc View 1 2 3 4 5 6 7 8 9 10 11 1 chunk +0 lines, -56 lines 0 comments Download
D webkit/glue/webcursor_aurax11.cc View 1 2 3 4 5 6 7 8 9 10 11 1 chunk +0 lines, -93 lines 0 comments Download
D webkit/glue/webcursor_gtk.cc View 1 2 3 4 5 6 7 8 9 10 11 1 chunk +0 lines, -222 lines 0 comments Download
D webkit/glue/webcursor_gtk_data.h View 1 2 3 4 5 6 7 8 9 10 11 1 chunk +0 lines, -311 lines 0 comments Download
D webkit/glue/webcursor_mac.mm View 1 2 3 4 5 6 7 8 9 10 11 1 chunk +0 lines, -428 lines 0 comments Download
D webkit/glue/webcursor_null.cc View 1 2 3 4 5 6 7 8 9 10 11 1 chunk +0 lines, -34 lines 0 comments Download
D webkit/glue/webcursor_unittest.cc View 1 2 3 4 5 6 7 8 9 10 11 1 chunk +0 lines, -244 lines 0 comments Download
D webkit/glue/webcursor_win.cc View 1 2 3 4 5 6 7 8 9 10 11 1 chunk +0 lines, -181 lines 0 comments Download
M webkit/glue/webkit_glue.gypi View 1 2 3 4 5 6 7 8 9 10 11 3 chunks +1 line, -27 lines 0 comments Download
M webkit/plugins/npapi/webplugin_delegate.h View 1 2 3 4 5 6 7 8 9 10 11 1 chunk +1 line, -1 line 0 comments Download
M webkit/plugins/npapi/webplugin_delegate_impl.h View 1 2 3 4 5 6 7 8 9 10 11 1 chunk +1 line, -1 line 0 comments Download
M webkit/plugins/npapi/webplugin_delegate_impl_android.cc View 1 2 3 4 5 6 7 8 9 10 11 1 chunk +1 line, -1 line 0 comments Download
M webkit/plugins/npapi/webplugin_delegate_impl_aura.cc View 1 2 3 4 5 6 7 8 9 10 11 1 chunk +1 line, -1 line 0 comments Download
M webkit/plugins/npapi/webplugin_delegate_impl_gtk.cc View 1 2 3 4 5 6 7 8 9 10 11 1 chunk +1 line, -1 line 0 comments Download
M webkit/plugins/npapi/webplugin_delegate_impl_mac.mm View 1 2 3 4 5 6 7 8 9 10 11 1 chunk +1 line, -1 line 0 comments Download
M webkit/plugins/npapi/webplugin_delegate_impl_win.cc View 1 2 3 4 5 6 7 8 9 10 11 1 chunk +1 line, -1 line 0 comments Download
M webkit/plugins/webkit_plugins.gypi View 1 2 3 4 5 6 7 8 9 10 11 1 chunk +1 line, -0 lines 0 comments Download
M webkit/support/webkit_support.gypi View 1 2 3 4 5 6 7 8 9 10 11 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
ananta
7 years, 6 months ago (2013-05-29 00:23:12 UTC) #1
jamesr
lgtm https://codereview.chromium.org/15971005/diff/1/content/browser/accessibility/browser_accessibility_win.cc File content/browser/accessibility/browser_accessibility_win.cc (right): https://codereview.chromium.org/15971005/diff/1/content/browser/accessibility/browser_accessibility_win.cc#newcode501 content/browser/accessibility/browser_accessibility_win.cc:501: return E_FAIL; is this change related? https://codereview.chromium.org/15971005/diff/1/webkit/common/webkit_common.gypi File ...
7 years, 6 months ago (2013-05-29 00:28:11 UTC) #2
ananta
https://codereview.chromium.org/15971005/diff/1/content/browser/accessibility/browser_accessibility_win.cc File content/browser/accessibility/browser_accessibility_win.cc (right): https://codereview.chromium.org/15971005/diff/1/content/browser/accessibility/browser_accessibility_win.cc#newcode501 content/browser/accessibility/browser_accessibility_win.cc:501: return E_FAIL; On 2013/05/29 00:28:11, jamesr wrote: > is ...
7 years, 6 months ago (2013-05-29 00:34:43 UTC) #3
ananta
+jam for content owners review.
7 years, 6 months ago (2013-05-29 19:22:40 UTC) #4
piman
lgtm
7 years, 6 months ago (2013-05-29 23:58:24 UTC) #5
ananta
+sky for chrome owners
7 years, 6 months ago (2013-05-30 00:10:24 UTC) #6
sky
LGTM
7 years, 6 months ago (2013-05-30 00:12:43 UTC) #7
palmer
rubberstamp LGTM for _messages.h
7 years, 6 months ago (2013-05-30 00:30:34 UTC) #8
ananta
+benm for android_webview OWNERS review.
7 years, 6 months ago (2013-05-30 01:02:31 UTC) #9
mnaganov (inactive)
LGTM for android_webview
7 years, 6 months ago (2013-05-30 17:13:16 UTC) #10
ananta
7 years, 6 months ago (2013-05-31 00:25:42 UTC) #11
Message was sent while issue was closed. 
Committed patchset #13 manually as r203280 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698