Index: content/browser/media/dtls_identity_store.h |
diff --git a/content/browser/media/dtls_identity_store.h b/content/browser/media/dtls_identity_store.h |
new file mode 100644 |
index 0000000000000000000000000000000000000000..33e4f404f4959de50f7c7799300163965f5e87d7 |
--- /dev/null |
+++ b/content/browser/media/dtls_identity_store.h |
@@ -0,0 +1,52 @@ |
+// Copyright (c) 2013 The Chromium Authors. All rights reserved. |
+// Use of this source code is governed by a BSD-style license that can be |
+// found in the LICENSE file. |
+ |
+#ifndef CONTENT_BROWSER_MEDIA_DTLS_IDENTITY_STORE_H_ |
+#define CONTENT_BROWSER_MEDIA_DTLS_IDENTITY_STORE_H_ |
+ |
+#include "base/callback.h" |
+#include "base/memory/ref_counted.h" |
+#include "base/memory/singleton.h" |
+ |
+class GURL; |
+ |
+namespace base { |
+class TaskRunner; |
+} // namespace base |
+ |
+namespace content { |
+ |
+// This is a singleton class called in the browser UI thread. |
+// It dispatches DTLS identity requests to the background worker thread. |
+class DTLSIdentityStore { |
+ public: |
+ static DTLSIdentityStore* GetInstance(); |
Ryan Sleevi
2013/06/04 19:13:52
DESIGN: No new singletons.
DESIGN: You can't mix t
jiayl
2013/06/05 00:08:09
What's the alternative to singleton? I tried to fi
Ryan Sleevi
2013/06/06 23:57:37
The alternative to a Singleton is not using a Sing
jiayl
2013/06/07 00:31:25
jam@, could you give some suggestion on who should
jam
2013/06/07 00:46:49
if this code is per profile, then it should either
|
+ DTLSIdentityStore(); |
+ DTLSIdentityStore(const scoped_refptr<base::TaskRunner>& task_runner); |
Ryan Sleevi
2013/06/04 19:13:52
STYLE: explicit
jiayl
2013/06/06 05:10:24
Done.
|
+ ~DTLSIdentityStore(); |
+ |
+ typedef base::Callback<void(const std::string&, const std::string&)> |
+ OnCompleteCallback; |
+ |
+ // Get the DTLS identity for the given domain of |url|, or generate a new one |
+ // if not existent. Asynchronous. Called on the browser UI thread. |
+ // |url| is the frame URL of the PeerConnection requesting the identity; |
Ryan Sleevi
2013/06/04 19:13:52
STYLE: terms like "frame URL" don't really fit her
jiayl
2013/06/06 05:10:24
Renamed to origin.
|
+ // |identity_name| is the name of the identity; |
+ // |common_name| ??? |
+ // |callback| is the callback to return the result. |
+ void GetOrGenerateIdentity(const GURL& url, |
+ const std::string& identity_name, |
+ const std::string& common_name, |
+ const OnCompleteCallback& callback |
Ryan Sleevi
2013/06/04 19:13:52
DESIGN: If a requester goes away while an identity
jiayl
2013/06/06 05:10:24
How can we tell a requester goes away? It seems th
Ryan Sleevi
2013/06/06 23:57:37
Yes.
You're going to be performing expensive oper
jiayl
2013/06/07 00:24:07
But ServerBoundCertService does not remove a cance
jiayl
2013/06/13 21:50:45
OK, now the request is cancelled when the DTLSIden
|
+ ); |
Ryan Sleevi
2013/06/04 19:13:52
STYLE: closing parens go on the same line as the l
jiayl
2013/06/06 05:10:24
Done.
|
+ private: |
+ friend struct DefaultSingletonTraits<DTLSIdentityStore>; |
+ |
+ // The TaskRunner for doing work on a worker thread. |
+ scoped_refptr<base::TaskRunner> task_runner_; |
+}; |
+ |
+} // namespace content |
+ |
+#endif // CONTENT_BROWSER_MEDIA_DTLS_IDENTITY_STORE_H_ |