Generates the DTLS identity in browser process and returns it to render process.

content/renderer/media/dtls_identity_service.h

+// Copyright (c) 2013 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef CONTENT_RENDERER_MEDIA_DTLS_IDENTITY_SERVICE_H_
+#define CONTENT_RENDERER_MEDIA_DTLS_IDENTITY_SERVICE_H_
+
+#include <string>
+
+#include "base/basictypes.h"
+#include "base/memory/scoped_ptr.h"
+#include "content/public/renderer/render_process_observer.h"
+#include "googleurl/src/gurl.h"
+
+namespace content {
+
+class DTLSIdentityObserver {

[Ami GONE FROM CHROMIUM, 2013/06/06 18:28:51]

Comment this is here only temporarily until it moves into libjingle, where the
impl will also live.

[jiayl, 2013/06/06 21:00:08]

Done.

[jiayl, 2013/06/06 21:00:08]

Done.

+ public:
+  virtual ~DTLSIdentityObserver() {}
+  virtual void OnCompleted(const std::string& certificate,
+                           const std::string& private_key) = 0;
+};
+
+// This class handles DTLS identity requests by sending IPC messages to the
+// browser process.
+// TODO: implement webrtc::DTLSIdentityServiceInterface from Libjingle.
+class DTLSIdentityService : public RenderProcessObserver {

[Ami GONE FROM CHROMIUM, 2013/06/06 18:28:51]

How is this working without calling RenderThread()::Get()->{Add,Remove}Observer
in the ctor/dtor ??
I don't understand how OCMR() is even being called.

[jiayl, 2013/06/06 21:00:08]

Oops, added these calls. I'm not sure how to test this in either unittest or
browser test. :(

+ public:
+  // |observer| is owned by DTLSIdentityService.

[Ami GONE FROM CHROMIUM, 2013/06/06 18:28:51]

Passing by scoped_ptr would allow the compiler to check this instead of relying
on a comment.

[jiayl, 2013/06/06 21:00:08]

Done.

[jiayl, 2013/06/06 21:00:08]

Done.

+  DTLSIdentityService(const GURL& origin,
+                      DTLSIdentityObserver* observer);
+  virtual ~DTLSIdentityService();
+
+  // Get the DTLS identity or generate a new one if not existent.
+  // |identity_name| is used to identity an identity within an origin.
+  // |common_name| is the common name used to generated the certificate.
+  virtual void GetOrGenerateIdentity(const std::string& identity_name,

[Ami GONE FROM CHROMIUM, 2013/06/06 18:28:51]

nit: name & comment still sound synchronous.
s/GetOrGenerate/Request/ ?

[jiayl, 2013/06/06 21:00:08]

Done.

[jiayl, 2013/06/06 21:00:08]

Done.

+                                     const std::string& common_name);
+
+ private:
+  // RenderProcessObserver implementation.
+  virtual bool OnControlMessageReceived(const IPC::Message& message) OVERRIDE;
+
+  void OnIdentityReady(const std::string& certificate,
+                       const std::string& private_key);
+
+  // The origin of the PeerConnection which owns this DTLSIdentityService.
+  GURL origin_;
+  scoped_ptr<DTLSIdentityObserver> observer_;
+
+  DISALLOW_COPY_AND_ASSIGN(DTLSIdentityService);
+};
+
+}  // namespace content
+
+#endif  // CONTENT_RENDERER_MEDIA_DTLS_IDENTITY_SERVICE_H_