Generates the DTLS identity in browser process and returns it to render process.

content/renderer/media/dtls_identity_service.h

+// Copyright (c) 2013 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef CONTENT_RENDERER_MEDIA_DTLS_IDENTITY_SERVICE_H_
+#define CONTENT_RENDERER_MEDIA_DTLS_IDENTITY_SERVICE_H_
+
+
+#include <string>
+#include "base/basictypes.h"
+#include "googleurl/src/gurl.h"
+
+namespace content {
+
+// This class handles DTLS identity requests by sending IPC messages to the
+// browser process.
+class DTLSIdentityService {
+ public:
+  DTLSIdentityService(const GURL& url);

[Ami GONE FROM CHROMIUM, 2013/06/04 19:29:09]

explicit

+  virtual ~DTLSIdentityService();

[Ami GONE FROM CHROMIUM, 2013/06/04 19:29:09]

virtual dtor implies you expect to be subclassed (as does the "virtual" on the
GOGI() below).  Is that really the case?

[jiayl, 2013/06/06 05:10:24]

It'll implement an interface defined by Libjingle for Libjingle to use, so it
should be virtual.

+
+  // Called on the renderer main thread to get the DTLS identity or geneate a

[Ami GONE FROM CHROMIUM, 2013/06/04 19:29:09]

typo: geneate

+  // new one if not existent.
+  // |identity_name| is the name of the identity;

[Ami GONE FROM CHROMIUM, 2013/06/04 19:29:09]

This is uninformative, and I am left not knowing what goes here.  Would an
example help?  Or a pointer to a spec for the functionality this provides?

+  // |common_name| ???;

[Ami GONE FROM CHROMIUM, 2013/06/04 19:29:09]

ditto^2

+  // |certificate| holds the returned certificate as a string;
+  // |private_key| holds the returned private key as a string.
+  virtual bool GetOrGenerateIdentity(const std::string& identity_name,

[Ami GONE FROM CHROMIUM, 2013/06/04 19:29:09]

"bool" implies failure is possible; what can cause failure?  I _think_ the
answer is "channel to the browser is closed", but I also think that's probably a
terminal condition.  Does this need to return bool as opposed to void+CHECK?

[jiayl, 2013/06/06 05:10:24]

It seems it never returns false for async msg. Changed to void.

+                                     const std::string& common_name,
+                                     std::string* certificate,
+                                     std::string* private_key);
+
+ private:
+  // The frame URL of the PeerConnection which owns this DTLSIdentityService.
+  GURL url_;
+
+  DISALLOW_COPY_AND_ASSIGN(DTLSIdentityService);

[Ami GONE FROM CHROMIUM, 2013/06/04 19:29:09]

DISALLOW_IMPLICIT_CONSTRUCTORS

+};
+
+}  // namespace content
+
+#endif  // CONTENT_RENDERER_MEDIA_DTLS_IDENTITY_SERVICE_H_