Warn by default when certain DLL conflicts exist on XP.

chrome/browser/ui/views/conflicting_module_view_win.cc

Index: chrome/browser/ui/views/conflicting_module_view_win.cc
diff --git a/chrome/browser/ui/views/conflicting_module_view_win.cc b/chrome/browser/ui/views/conflicting_module_view_win.cc
new file mode 100644
index 0000000000000000000000000000000000000000..18d54091b47e85a1d1e8767e6b4650f2ee6e1820
--- /dev/null
+++ b/chrome/browser/ui/views/conflicting_module_view_win.cc
@@ -0,0 +1,225 @@
+// Copyright (c) 2013 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "chrome/browser/ui/views/conflicting_module_view_win.h"
+
+#include "base/metrics/histogram.h"
+#include "chrome/browser/enumerate_modules_model_win.h"
+#include "chrome/browser/profiles/profile.h"
+#include "chrome/browser/ui/browser.h"
+#include "chrome/common/chrome_notification_types.h"
+#include "chrome/common/pref_names.h"
+#include "content/public/browser/notification_service.h"
+#include "content/public/browser/user_metrics.h"
+#include "grit/chromium_strings.h"
+#include "grit/generated_resources.h"
+#include "grit/locale_settings.h"
+#include "grit/theme_resources.h"
+#include "ui/base/accessibility/accessible_view_state.h"
+#include "ui/base/l10n/l10n_util.h"
+#include "ui/base/resource/resource_bundle.h"
+#include "ui/views/controls/button/label_button.h"
+#include "ui/views/controls/image_view.h"
+#include "ui/views/controls/label.h"
+#include "ui/views/layout/grid_layout.h"
+#include "ui/views/layout/layout_constants.h"
+#include "ui/views/widget/widget.h"
+
+using content::UserMetricsAction;
+
+namespace {
+
+// Layout constants.
+const int kInsetBottomRight = 13;
+const int kInsetLeft = 14;
+const int kInsetTop = 9;
+const int kHeadlineMessagePadding = 4;
+const int kMessageBubblePadding = 11;
+
+// How often to show this bubble.
+const int kShowConflictingModuleBubbleMax = 3;
+
+}  // namespace
+
+////////////////////////////////////////////////////////////////////////////////
+// ConflictingModuleView
+
+ConflictingModuleView::ConflictingModuleView(
+    views::View* anchor_view,
+    Browser* browser,
+    const GURL& help_center_url)
+    : BubbleDelegateView(anchor_view, views::BubbleBorder::TOP_RIGHT),
+      browser_(browser),
+      explanation_(NULL),
+      learn_more_button_(NULL),
+      not_now_button_(NULL),
+      help_center_url_(help_center_url) {
+  set_close_on_deactivate(false);
+  set_move_with_anchor(true);
+  set_close_on_esc(true);
+
+  // Compensate for built-in vertical padding in the anchor view's image.
+  set_anchor_view_insets(gfx::Insets(5, 0, 5, 0));
+
+  registrar_.Add(this, chrome::NOTIFICATION_MODULE_INCOMPATIBILITY_BADGE_CHANGE,
+                 content::NotificationService::AllSources());
+}
+
+// static
+void ConflictingModuleView::MaybeShow(Browser* browser,
+                                      views::View* anchor_view) {
+  static bool done_checking = false;
+  if (done_checking)
+    return;  // Only show the bubble once per launch.
+
+  EnumerateModulesModel* model = EnumerateModulesModel::GetInstance();

[cpu_(ooo_6.6-7.5), 2013/06/04 03:01:58]

is this slow?

[Finnur, 2013/06/04 15:51:16]

The answer to that is: it's complicated. :)

The actual creation of this object is very fast. I timed this with
GetTickCount() on the debug build on my Win7 machine and it took less than a
millisecond every single time, as I'd expect it to (since it doesn't do much
immediately). However, it sets in motion a process (scanning modules) that runs
on the file thread further down the line and that process is more
time-consuming.

We are fortunate enough, since the scanner is already implemented, to know
exactly how long this takes by looking at UMA data
(Conflicts.EnumerationTotalTime) and it shows we have about ten and a half
thousand timing samples, from people who opted in through about:flags. Results:

For a quarter (25%) of our users it takes less than 230 ms to enumerate and
compare all modules on the system against the blacklist, sort the list and
report back to the observers.
For a slim majority of users this process takes less than 755 ms.
Once we get to the 80th percentile (of users) we're seeing numbers like 3000 ms
and then it starts tapering off into the long tail from there.

The question is, will this have an adverse effect on:
1) Performance testing bots on XP?
2) Perceived performance by users on XP?
3) Performance testing in the wild on XP?

I think we'll need to pick a conservative delay (some minutes after startup) in
an effort to decrease the likelihood that this will affect the above.

+  GURL url = model->GetFirstNotableConflict();
+  if (!url.is_valid()) {
+    done_checking = true;
+    return;
+  }
+
+  // A pref that counts how often the Sideload Wipeout bubble has been shown.
+  IntegerPrefMember bubble_shown;
+  bubble_shown.Init(prefs::kModuleConflictBubbleShown,
+                    browser->profile()->GetPrefs());
+  if (bubble_shown.GetValue() >= kShowConflictingModuleBubbleMax) {
+    done_checking = true;
+    return;
+  }
+
+  ConflictingModuleView* bubble_delegate =
+      new ConflictingModuleView(anchor_view, browser, url);
+  views::BubbleDelegateView::CreateBubble(bubble_delegate);
+  bubble_delegate->ShowBubble();
+
+  done_checking = true;
+}
+
+////////////////////////////////////////////////////////////////////////////////
+// ConflictingModuleView - private.
+
+ConflictingModuleView::~ConflictingModuleView() {
+}
+
+void ConflictingModuleView::ShowBubble() {
+  StartFade(true);
+
+  IntegerPrefMember bubble_shown;
+  bubble_shown.Init(
+      prefs::kModuleConflictBubbleShown,
+      browser_->profile()->GetPrefs());
+  bubble_shown.SetValue(bubble_shown.GetValue() + 1);
+}
+
+void ConflictingModuleView::DismissBubble() {
+  GetWidget()->Close();
+
+  content::RecordAction(
+      UserMetricsAction("ConflictingModuleNotificationDismissed"));
+}
+
+void ConflictingModuleView::Init() {
+  ui::ResourceBundle& rb = ui::ResourceBundle::GetSharedInstance();
+
+  views::GridLayout* layout = views::GridLayout::CreatePanel(this);
+  layout->SetInsets(kInsetTop, kInsetLeft,
+                    kInsetBottomRight, kInsetBottomRight);
+  SetLayoutManager(layout);
+
+  views::ImageView* icon = new views::ImageView();
+  icon->SetImage(rb.GetNativeImageNamed(IDR_INPUT_ALERT_MENU).ToImageSkia());
+  gfx::Size icon_size = icon->GetPreferredSize();
+
+  const int text_column_set_id = 0;
+  views::ColumnSet* upper_columns = layout->AddColumnSet(text_column_set_id);
+  upper_columns->AddColumn(
+      views::GridLayout::LEADING, views::GridLayout::LEADING,
+      0, views::GridLayout::FIXED, icon_size.width(), icon_size.height());
+  upper_columns->AddPaddingColumn(0, 7);

[cpu_(ooo_6.6-7.5), 2013/06/04 03:01:58]

is that 7 one of our constants? Or can it be rephrased as one, kRelatedFoo + 1
kind of thing at least?

+  upper_columns->AddColumn(
+      views::GridLayout::LEADING, views::GridLayout::LEADING,
+      0, views::GridLayout::USE_PREF, 0, 0);
+
+  layout->StartRowWithPadding(
+      0, text_column_set_id, 0, kHeadlineMessagePadding);
+  layout->AddView(icon);
+  explanation_ = new views::Label();
+  explanation_->SetMultiLine(true);
+  explanation_->SetHorizontalAlignment(gfx::ALIGN_LEFT);
+  explanation_->SetText(l10n_util::GetStringUTF16(
+      IDS_OPTIONS_CONFLICTING_MODULE));
+  explanation_->SizeToFit(views::Widget::GetLocalizedContentsWidth(
+      IDS_CONFLICTING_MODULE_BUBBLE_WIDTH_CHARS));
+  layout->AddView(explanation_);
+
+  const int action_row_column_set_id = 1;
+  views::ColumnSet* bottom_columns =
+      layout->AddColumnSet(action_row_column_set_id);
+  bottom_columns->AddPaddingColumn(1, 0);
+  bottom_columns->AddColumn(views::GridLayout::TRAILING,
+      views::GridLayout::CENTER, 0, views::GridLayout::USE_PREF, 0, 0);
+  bottom_columns->AddPaddingColumn(0, views::kRelatedButtonHSpacing);
+  bottom_columns->AddColumn(views::GridLayout::TRAILING,
+      views::GridLayout::CENTER, 0, views::GridLayout::USE_PREF, 0, 0);
+  layout->AddPaddingRow(0, 7);
+
+  layout->StartRowWithPadding(0, action_row_column_set_id,
+                              0, kMessageBubblePadding);
+  learn_more_button_ = new views::LabelButton(this,
+      l10n_util::GetStringUTF16(IDS_CONFLICTS_LEARN_MORE));
+  learn_more_button_->SetStyle(views::Button::STYLE_NATIVE_TEXTBUTTON);
+  layout->AddView(learn_more_button_);
+  not_now_button_ = new views::LabelButton(this,
+      l10n_util::GetStringUTF16(IDS_CONFLICTS_NOT_NOW));
+  not_now_button_->SetStyle(views::Button::STYLE_NATIVE_TEXTBUTTON);
+  layout->AddView(not_now_button_);
+
+  content::RecordAction(
+      UserMetricsAction("ConflictingModuleNotificationShown"));
+
+  UMA_HISTOGRAM_ENUMERATION("ConflictingModule.UserSelection",
+      EnumerateModulesModel::ACTION_BUBBLE_SHOWN,
+      EnumerateModulesModel::ACTION_BOUNDARY);
+}
+
+void ConflictingModuleView::ButtonPressed(views::Button* sender,
+                                          const ui::Event& event) {
+  if (sender == learn_more_button_) {
+    EnumerateModulesModel::RecordLearnMoreStat(false);
+    browser_->OpenURL(
+        content::OpenURLParams(help_center_url_,
+                               content::Referrer(),
+                               NEW_FOREGROUND_TAB,
+                               content::PAGE_TRANSITION_LINK,
+                               false));
+
+    EnumerateModulesModel* model = EnumerateModulesModel::GetInstance();
+    model->AcknowledgeConflictNotification();
+    DismissBubble();
+  } else if (sender == not_now_button_) {
+    DismissBubble();
+  }
+}
+
+void ConflictingModuleView::GetAccessibleState(
+    ui::AccessibleViewState* state) {
+  state->role = ui::AccessibilityTypes::ROLE_ALERT;
+}
+
+void ConflictingModuleView::ViewHierarchyChanged(
+  const ViewHierarchyChangedDetails& details) {
+  if (details.is_add && details.child == this)
+    NotifyAccessibilityEvent(ui::AccessibilityTypes::EVENT_ALERT, true);
+}
+
+void ConflictingModuleView::Observe(
+    int type,
+    const content::NotificationSource& source,
+    const content::NotificationDetails& details) {
+  DCHECK(type == chrome::NOTIFICATION_MODULE_INCOMPATIBILITY_BADGE_CHANGE);
+  EnumerateModulesModel* model = EnumerateModulesModel::GetInstance();
+  if (!model->ShouldShowConflictWarning())
+    GetWidget()->Close();
+}