Warn by default when certain DLL conflicts exist on XP.

chrome/browser/enumerate_modules_model_unittest_win.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/string_util.h"
 #include "base/strings/string_number_conversions.h"
 #include "base/utf_string_conversions.h"
 #include "chrome/browser/enumerate_modules_model_win.h"
 #include "testing/gtest/include/gtest/gtest.h"
 
 typedef testing::Test EnumerateModulesTest;
 
 // Set up some constants to use as default when creating the structs.
 static const ModuleEnumerator::ModuleType kType =
     ModuleEnumerator::LOADED_MODULE;
 
 static const ModuleEnumerator::ModuleStatus kStatus =
     ModuleEnumerator::NOT_MATCHED;
 
 static const ModuleEnumerator::RecommendedAction kAction =
     ModuleEnumerator::NONE;
 
+static const ModuleEnumerator::OperatingSystem kOs =
+    ModuleEnumerator::ALL;
+
 // This is a list of test cases to normalize.
 static const struct NormalizationEntryList {
   ModuleEnumerator::Module test_case;
   ModuleEnumerator::Module expected;
 } kNormalizationTestCases[] = {
   {
     // Only path normalization needed.
     {kType, kStatus, L"c:\\foo\\bar.dll", L"",        L"Prod", L"Desc", L"1.0",
          L"Sig", kAction},
     {kType, kStatus, L"c:\\foo\\",        L"bar.dll", L"Prod", L"Desc", L"1.0",
@@ skipping 69 matching lines @@
   ModuleEnumerator::ModuleStatus expected_result;
   ModuleEnumerator::Module test_case;
   ModuleEnumerator::BlacklistEntry blacklist;
 } kMatchineEntryList[] = {
   // Each BlacklistEntry is:
   // Filename, location, desc_or_signer, version from, version to, help_tip.
 
   {  // Matches: Name (location doesn't match) => Not enough for a match.
     ModuleEnumerator::NOT_MATCHED,
     kStandardModule,
-    { kMatchName, kNoMatchLocation, kEmpty, kEmpty, kEmpty,
+    { kMatchName, kNoMatchLocation, kEmpty, kEmpty, kEmpty, kOs,
       ModuleEnumerator::SEE_LINK }
   }, {  // Matches: Name (location not given) => Suspected match.
     ModuleEnumerator::SUSPECTED_BAD,
     kStandardModule,
-    { kMatchName, kEmpty, kEmpty, kEmpty, kEmpty,
+    { kMatchName, kEmpty, kEmpty, kEmpty, kEmpty, kOs,
       ModuleEnumerator::SEE_LINK }
   }, {  // Matches: Name, not version (location not given) => Not a match.
     ModuleEnumerator::NOT_MATCHED,
     kStandardModule,
-    { kMatchName, kEmpty, kEmpty, kVersionHigh, kVersionHigh,
+    { kMatchName, kEmpty, kEmpty, kVersionHigh, kVersionHigh, kOs,
       ModuleEnumerator::SEE_LINK }
   }, {  // Matches: Name, location => Suspected match.
     ModuleEnumerator::SUSPECTED_BAD,
     kStandardModule,
-    { kMatchName, kMatchLocation, kEmpty, kEmpty, kEmpty,
+    { kMatchName, kMatchLocation, kEmpty, kEmpty, kEmpty, kOs,
       ModuleEnumerator::SEE_LINK }
   }, {  // Matches: Name, location, (description not given) => Confirmed match.
     ModuleEnumerator::CONFIRMED_BAD,
     kStandardModuleNoDescription,  // Note: No description.
-    { kMatchName, kMatchLocation, kEmpty, kEmpty, kEmpty,
+    { kMatchName, kMatchLocation, kEmpty, kEmpty, kEmpty, kOs,
       ModuleEnumerator::SEE_LINK }
   }, {  // Matches: Name, location, (signature not given) => Confirmed match.
     ModuleEnumerator::CONFIRMED_BAD,
     kStandardModuleNoSignature,  // Note: No signature.
-    { kMatchName, kMatchLocation, kEmpty, kEmpty, kEmpty,
+    { kMatchName, kMatchLocation, kEmpty, kEmpty, kEmpty, kOs,
       ModuleEnumerator::SEE_LINK }
   }, {  // Matches: Name, location (not version) => Not a match.
     ModuleEnumerator::NOT_MATCHED,
     kStandardModule,
-    { kMatchName, kMatchLocation, kEmpty, kVersionHigh, kVersionLow,
+    { kMatchName, kMatchLocation, kEmpty, kVersionHigh, kVersionLow, kOs,
       ModuleEnumerator::SEE_LINK }
   }, {  // Matches: Name, location, signature => Confirmed match.
     ModuleEnumerator::CONFIRMED_BAD,
     kStandardModule,
-    { kMatchName, kMatchLocation, kMatchSignature, kEmpty, kEmpty,
+    { kMatchName, kMatchLocation, kMatchSignature, kEmpty, kEmpty, kOs,
       ModuleEnumerator::SEE_LINK }
   }, {  // Matches: Name, location, signature (not version) => No match.
     ModuleEnumerator::NOT_MATCHED,
     kStandardModule,
     { kMatchName, kMatchLocation, kMatchSignature,
-      kVersionLow, kVersionLow, ModuleEnumerator::SEE_LINK }
+      kVersionLow, kVersionLow, kOs, ModuleEnumerator::SEE_LINK }
   }, {  // Matches: Name, location, description => Confirmed match.
     ModuleEnumerator::CONFIRMED_BAD,
     kStandardModule,
-    { kMatchName, kMatchLocation, kMatchDesc, kEmpty, kEmpty,
+    { kMatchName, kMatchLocation, kMatchDesc, kEmpty, kEmpty, kOs,
       ModuleEnumerator::SEE_LINK }
   }, {  // Matches: Name, location, description (not version) => No match.
     ModuleEnumerator::NOT_MATCHED,
     kStandardModule,
     { kMatchName, kMatchLocation, kMatchDesc,
-      kVersionHigh, kVersionHigh, ModuleEnumerator::SEE_LINK }
+      kVersionHigh, kVersionHigh, kOs, ModuleEnumerator::SEE_LINK }
   }, {  // Matches: Name, location, signature, version => Confirmed match.
     ModuleEnumerator::CONFIRMED_BAD,
     kStandardModule,
     { kMatchName, kMatchLocation, kMatchSignature,
-      kVersionLow, kVersionHigh, ModuleEnumerator::SEE_LINK }
+      kVersionLow, kVersionHigh, kOs, ModuleEnumerator::SEE_LINK }
   }, {  // Matches: Name, location, signature, version (lower) => Confirmed.
     ModuleEnumerator::CONFIRMED_BAD,
     kStandardModule,
     { kMatchName, kMatchLocation, kMatchSignature,
-      kVersionLow, kEmpty, ModuleEnumerator::SEE_LINK }
+      kVersionLow, kEmpty, kOs, ModuleEnumerator::SEE_LINK }
   }, {  // Matches: Name, location, signature, version (upper) => Confirmed.
     ModuleEnumerator::CONFIRMED_BAD,
     kStandardModule,
     { kMatchName, kMatchLocation, kMatchSignature,
-      kEmpty, kVersionHigh, ModuleEnumerator::SEE_LINK }
+      kEmpty, kVersionHigh, kOs, ModuleEnumerator::SEE_LINK }
   }, {  // Matches: Name, Location, Version lower is inclusive => Confirmed.
     ModuleEnumerator::CONFIRMED_BAD,
     kStandardModule,
     { kMatchName, kMatchLocation, kMatchSignature,
-      "1.0", "2.0", ModuleEnumerator::SEE_LINK }
+      "1.0", "2.0", kOs, ModuleEnumerator::SEE_LINK }
   }, {  // Matches: Name, Location, Version higher is exclusive => No match.
     ModuleEnumerator::NOT_MATCHED,
     kStandardModule,
     { kMatchName, kMatchLocation, kEmpty,
-      "0.0", "1.0", ModuleEnumerator::SEE_LINK }
+      "0.0", "1.0", kOs, ModuleEnumerator::SEE_LINK }
   }, {  // All empty fields doesn't produce a match.
     ModuleEnumerator::NOT_MATCHED,
     { kType, kStatus, L"", L"", L"", L"", L""},
-    { "a.dll", "", "", "", "", ModuleEnumerator::SEE_LINK }
+    { "a.dll", "", "", "", "", kOs, ModuleEnumerator::SEE_LINK }
   },
 };
 
 TEST_F(EnumerateModulesTest, MatchFunction) {
   for (size_t i = 0; i < arraysize(kMatchineEntryList); ++i) {
     ModuleEnumerator::Module test = kMatchineEntryList[i].test_case;
     ModuleEnumerator::NormalizeModule(&test);
     ModuleEnumerator::BlacklistEntry blacklist =
         kMatchineEntryList[i].blacklist;
 
@@ skipping 27 matching lines @@
     ModuleEnumerator::Module module;
     module.location = kCollapsePathList[i].test_case;
     module_enumerator->CollapsePath(&module);
 
     SCOPED_TRACE("Test case no " + base::IntToString(i) +
                  ": '" + UTF16ToASCII(kCollapsePathList[i].expected_result) +
                  "'");
     EXPECT_EQ(kCollapsePathList[i].expected_result, module.location);
   }
 }